test: move test-cluster-debug-port to sequential #16292
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This test cannot be run in parallel, as it can conflict with other tests using the debug port.
gibfahn approved these changes Oct 18, 2017
Member
gibfahn commented Oct 18, 2017
Note that this test has already been removed from cc/ @nodejs/testing |
cjihrig approved these changes Oct 18, 2017
daxlab approved these changes Oct 18, 2017
jasnell approved these changes Oct 18, 2017
MylesBorinsforce-pushed the v6.x-staging branch from 6c73628 to d01978eCompare
benjamingr approved these changes Oct 18, 2017
trivikr approved these changes Oct 19, 2017
MylesBorins pushed a commit that referenced this pull request Oct 19, 2017
This test cannot be run in parallel, as it can conflict with other tests using the debug port. PR-URL: #16292 Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
Contributor
MylesBorins commented Oct 19, 2017
landed in f65f691 |
MylesBorins pushed a commit that referenced this pull request Oct 19, 2017
This test cannot be run in parallel, as it can conflict with other tests using the debug port. PR-URL: #16292 Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
Merged
MylesBorins pushed a commit that referenced this pull request Oct 25, 2017
This test cannot be run in parallel, as it can conflict with other tests using the debug port. PR-URL: #16292 Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
MylesBorins pushed a commit that referenced this pull request Oct 25, 2017
This test cannot be run in parallel, as it can conflict with other tests using the debug port. PR-URL: #16292 Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
Merged
MylesBorins pushed a commit that referenced this pull request Oct 26, 2017
This test cannot be run in parallel, as it can conflict with other tests using the debug port. PR-URL: #16292 Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test cannot be run in parallel, as it can conflict with other tests using the debug port. I suggest making this test
sequential.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test