http2: fix compiler errors in debug statements#16373
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
When compiling with --debug-http2 flag, compiler complains about passing wrong type of argument to DEBUG_HTTP2. Fix by using static_cast to uint32_t.
nodejs-github-bot added c++ 
ContributorAuthor
apapirovski commented Oct 22, 2017
jasnell approved these changes Oct 22, 2017
Member
jasnell left a comment
jasnell left a comment There was a problem hiding this comment.
Out of curiosity what os are you building on?
ContributorAuthor
apapirovski commented Oct 22, 2017
@jasnell I'm on macOS 10.12.6. |
Member
jasnell commented Oct 22, 2017
Ok. I haven't built on Mac with the --debug-http2 option in quite some time. Thanks for catching that! :) |
apapirovski added a commit that referenced this pull request Oct 24, 2017
When compiling with --debug-http2 flag, compiler complains about passing wrong type of argument to DEBUG_HTTP2. Fix by using static_cast to uint32_t. PR-URL: #16373 Reviewed-By: James M Snell <[email protected]>
ContributorAuthor
apapirovski commented Oct 24, 2017
Landed in 47ed02c |
addaleax pushed a commit to ayojs/ayo that referenced this pull request Oct 26, 2017
When compiling with --debug-http2 flag, compiler complains about passing wrong type of argument to DEBUG_HTTP2. Fix by using static_cast to uint32_t. PR-URL: nodejs/node#16373 Reviewed-By: James M Snell <[email protected]>
gibfahn pushed a commit that referenced this pull request Oct 30, 2017
When compiling with --debug-http2 flag, compiler complains about passing wrong type of argument to DEBUG_HTTP2. Fix by using static_cast to uint32_t. PR-URL: #16373 Reviewed-By: James M Snell <[email protected]>
gibfahn pushed a commit that referenced this pull request Oct 31, 2017
When compiling with --debug-http2 flag, compiler complains about passing wrong type of argument to DEBUG_HTTP2. Fix by using static_cast to uint32_t. PR-URL: #16373 Reviewed-By: James M Snell <[email protected]>
Merged
addaleax pushed a commit to ayojs/ayo that referenced this pull request Dec 7, 2017
When compiling with --debug-http2 flag, compiler complains about passing wrong type of argument to DEBUG_HTTP2. Fix by using static_cast to uint32_t. PR-URL: nodejs/node#16373 Reviewed-By: James M Snell <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When compiling with
--debug-http2flag, compiler complains about passing wrong type of argument toDEBUG_HTTP2. I'm not certain if this is something about my system or if I'm missing something here since no one else has noticed... then again maybe I'm the only one using--debug-http2at this moment.This fixes the issue by casting to
uint32_t.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
http2