build: make test-doc and lint addon docs#16377
Uh oh!
There was an error while loading. Please reload this page.
Conversation
nodejs-github-bot added the build 
joyeecheung commented Oct 22, 2017
BTW, why we abstain from making docs and running recently added doc tests on Windows? Is it from cc @nodejs/platform-windows |
gibfahn commented Oct 22, 2017
I think it's just waiting for someone to implement. |
gibfahn commented Oct 22, 2017
@joyeecheung so what's the difference between Is |
joyeecheung commented Oct 22, 2017
@gibfahn That's the plan |
Makefile Outdated
There was a problem hiding this comment.
Why just here? shouldn't this be handled in a global manner? Or just err with the message "to run with a precompiled node binary run make NODE=<path_to_node> <target>"
joyeecheungforce-pushed the test-doc-target branch from f85887a to de6d72aCompareFigured out why the linter failed (ci doesn't build the addon docs before linting them). @refack I gave the global New CI: https://ci.nodejs.org/job/node-test-pull-request/11038/ |
doc/api/addons.md Outdated
There was a problem hiding this comment.
Yes, needs two spaces here
refack commented Oct 28, 2017
Change looks good, but I'm assuming it's not well covered by CI?
|
- Implements the make test-doc target that build, verify and lint docs - Lint the C++ snippets in addon docs - When generating addons and running the JS linter, use the global node executable if it is not built. Therefore one does not have to build node in order to run make test-doc.
joyeecheungforce-pushed the test-doc-target branch from 13f210f to 87167a5Comparejoyeecheung commented Oct 29, 2017
Rebased & squashed. New CI: https://ci.nodejs.org/job/node-test-pull-request/11063/ |
joyeecheung commented Oct 30, 2017
Going to land this later today. |
- Implements the make test-doc target that build, verify and lint docs - Lint the C++ snippets in addon docs - When generating addons and running the JS linter, use the global node executable if it is not built. Therefore one does not have to build node in order to run make test-doc. PR-URL: #16377 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
joyeecheung commented Oct 30, 2017
Landed in 390eda1, thanks! |
- Implements the make test-doc target that build, verify and lint docs - Lint the C++ snippets in addon docs - When generating addons and running the JS linter, use the global node executable if it is not built. Therefore one does not have to build node in order to run make test-doc. PR-URL: #16377 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
- Implements the make test-doc target that build, verify and lint docs - Lint the C++ snippets in addon docs - When generating addons and running the JS linter, use the global node executable if it is not built. Therefore one does not have to build node in order to run make test-doc. PR-URL: #16377 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
- Implements the make test-doc target that build, verify and lint docs - Lint the C++ snippets in addon docs - When generating addons and running the JS linter, use the global node executable if it is not built. Therefore one does not have to build node in order to run make test-doc. PR-URL: #16377 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
- Implements the make test-doc target that build, verify and lint docs - Lint the C++ snippets in addon docs - When generating addons and running the JS linter, use the global node executable if it is not built. Therefore one does not have to build node in order to run make test-doc. PR-URL: nodejs/node#16377 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
- Implements the make test-doc target that build, verify and lint docs - Lint the C++ snippets in addon docs - When generating addons and running the JS linter, use the global node executable if it is not built. Therefore one does not have to build node in order to run make test-doc. PR-URL: nodejs/node#16377 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
- Implements the make test-doc target that build, verify and lint docs - Lint the C++ snippets in addon docs - When generating addons and running the JS linter, use the global node executable if it is not built. Therefore one does not have to build node in order to run make test-doc. PR-URL: nodejs#16377 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
- Implements the make test-doc target that build, verify and lint docs - Lint the C++ snippets in addon docs - When generating addons and running the JS linter, use the global node executable if it is not built. Therefore one does not have to build node in order to run make test-doc. PR-URL: nodejs/node#16377 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
MylesBorins added the baking-for-lts 
MylesBorins removed the baking-for-lts 7 participants
Prepping for nodejs/build#929
make test-doctarget that build, verify and lint docsmake test-doc.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test, tools