zlib: finish migrating to internal/errors#16540
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
jasnell added errors 
nodejs-github-bot added c++ 
MemberAuthor
jasnell commented Oct 27, 2017
ping @nodejs/tsc |
XadillaX approved these changes Oct 27, 2017
joyeecheung approved these changes Oct 27, 2017
src/node_zlib.cc Outdated
Member
There was a problem hiding this comment.
Any reason we need a goto here? (other than one less line of duplicate code?)
MemberAuthor
There was a problem hiding this comment.
just that... didn't want to duplicate the line of code
Member
joyeecheung commented Oct 27, 2017
lpinca approved these changes Oct 27, 2017
lpinca reviewed Oct 27, 2017
Member
There was a problem hiding this comment.
We need a new way to test this error once #16511 is merged.
jasnellforce-pushed the migrate-zlib-internal-errors branch from 0257a1d to c8ef9c3Comparejasnell added a commit that referenced this pull request Oct 29, 2017
PR-URL: #16540 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Khaidi Chu <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
MemberAuthor
jasnell commented Oct 29, 2017
Landed in 896eaf6 |
Qard pushed a commit to ayojs/ayo that referenced this pull request Nov 2, 2017
PR-URL: nodejs/node#16540 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Khaidi Chu <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Qard pushed a commit to ayojs/ayo that referenced this pull request Nov 2, 2017
PR-URL: nodejs/node#16540 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Khaidi Chu <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
addaleax pushed a commit to ayojs/ayo that referenced this pull request Dec 7, 2017
PR-URL: nodejs/node#16540 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Khaidi Chu <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finish migrating the zlib binding over to use internal/errors
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
zlib, errors