Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 34.2k
build: suppress lint-md output#16551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Conversation
gibfahn commented Oct 27, 2017
Previous output after installing remark:▶ make lint ~/wrk/com/DANGER/node (master) Running JS linter... ./node tools/eslint/bin/eslint.js --cache --rulesdir=tools/eslint-rules --ext=.js,.mjs,.md \ benchmark doc lib test tools Running C++ linter... Total errors found: 0 if [ !-d tools/remark-cli/node_modules ];then \ cd tools/remark-cli && ../.././node ../.././deps/npm/bin/npm-cli.js install;fiif [ !-d tools/remark-preset-lint-node/node_modules ];then \ cd tools/remark-preset-lint-node && ../.././node ../.././deps/npm/bin/npm-cli.js install;fi Running Markdown linter... ./node tools/remark-cli/cli.js -q -f \ ./*.md doc src lib benchmark tools/doc/ tools/icu/New output after installing remark▶ make lint ~/wrk/com/node (quiet-lint*) Running JS linter... ./node tools/eslint/bin/eslint.js --cache --rulesdir=tools/eslint-rules --ext=.js,.mjs,.md \ benchmark doc lib test tools Running C++ linter... Total errors found: 0 Running Markdown linter... ./node tools/remark-cli/cli.js -q -f \ ./*.md doc src lib benchmark tools/doc/ tools/icu/Output when you install remarkMarkdown linter: installing remark-cli into tools/ >[email protected] install /Users/gib/wrk/com/node/tools/remark-cli/node_modules/fsevents > node install [... lots of npm output here ...] added 272 packages in 8.462s Markdown linter: installing remark-preset-lint-node into tools/ npm notice created a lockfile as package-lock.json. You should commit this file. npm WARN You are using a pre-release version of node and things may not work as expected added 48 packages in 2.016s Running Markdown linter... ./node tools/remark-cli/cli.js -q -f \ ./*.md doc src lib benchmark tools/doc/ tools/icu/ make: *** [lint] Error 2I think keeping the npm install output is important. |
Florian-R commented Oct 27, 2017
Dupe of #16508 no? |
apapirovski left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I slightly prefer this one, or if @danbev modifies theirs to match. I don't think it should be made completely silent.
gibfahn commented Oct 27, 2017
gibfahn commented Oct 30, 2017
gibfahn commented Oct 31, 2017
Better fix at #16635, will close if that lands. |
We don't need to print out the output if we've already installed it, at the same time we do want to see some output when we haven't installed. PR-URL: nodejs#16551 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Khaidi Chu <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]>
We don't need to print out the output if we've already installed it, at the same time we do want to see some output when we haven't installed. PR-URL: nodejs#16551 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Khaidi Chu <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]>
We don't need to print out the output if we've already installed it, at the same time we do want to see some output when we haven't installed. PR-URL: #16551 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Khaidi Chu <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]>
We don't need to print out the output if we've already installed it, at
the same time we do want to see some output when we haven't installed.
Checklist
Affected core subsystem(s)
build