doc: add docs for Zlib#close()#16592
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added doc 
jasnell approved these changes Oct 29, 2017
gibfahn approved these changes Oct 29, 2017
addaleax approved these changes Oct 29, 2017
gireeshpunathil approved these changes Oct 30, 2017
Member
gireeshpunathil left a comment
gireeshpunathil left a comment There was a problem hiding this comment.
On a side note, I see API docs (inconsistently) use statements that are in:imperative mood such asCompress a chunk of data with Gzip.
and declarative mood such asCreates and returns a new Deflate object with the given options.
probably makes sense to unify them (I like the declarative style), a future code-and-learn candidate?
Contributor
daxlab commented Oct 30, 2017
daxlab approved these changes Oct 30, 2017
cjihrig approved these changes Oct 30, 2017
lpinca added a commit that referenced this pull request Nov 3, 2017
PR-URL: #16592 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
lpincaforce-pushed the add/docs-for-zlib-close branch from fb2d28b to 562ea89CompareMemberAuthor
lpinca commented Nov 3, 2017
Landed in 562ea89. |
cjihrig pushed a commit to cjihrig/node that referenced this pull request Nov 6, 2017
PR-URL: nodejs#16592 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Merged
MylesBorins pushed a commit that referenced this pull request Nov 14, 2017
PR-URL: #16592 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
gibfahn pushed a commit that referenced this pull request Nov 14, 2017
PR-URL: #16592 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Merged
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add docs for
Zlib.prototype.close().Checklist
Affected core subsystem(s)
doc