doc: fix Changelog link order#16632
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added the meta 
cjihrig approved these changes Oct 31, 2017
mscdex reviewed Oct 31, 2017
CHANGELOG.md Outdated
Contributor
There was a problem hiding this comment.
Should this line (mostly the io.js part) also technically be inserted between 0.12 and v4?
mscdex reviewed Oct 31, 2017
CHANGELOG.md Outdated
Contributor
There was a problem hiding this comment.
These two lines should probably be prefixed with 'Node.js' also.
gireeshpunathil approved these changes Oct 31, 2017
lpinca approved these changes Oct 31, 2017
MemberAuthor
gibfahn commented Oct 31, 2017
@mscdex updated, PTAL |
apapirovski approved these changes Oct 31, 2017
mscdex reviewed Oct 31, 2017
CHANGELOG.md Outdated
Contributor
There was a problem hiding this comment.
We can remove these commas now.
mscdex reviewed Oct 31, 2017
CHANGELOG.md Outdated
Contributor
There was a problem hiding this comment.
This comma still needs to be removed.
Contributor
mscdex commented Oct 31, 2017
LGTM |
tniessen approved these changes Nov 1, 2017
XadillaX approved these changes Nov 2, 2017
Contributor
XadillaX commented Nov 2, 2017
Landed in 94b2be7. |
XadillaX pushed a commit that referenced this pull request Nov 2, 2017
PR-URL: #16632 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Khaidi Chu <[email protected]> Reviewed-By: Brian White <[email protected]>
Qard pushed a commit to ayojs/ayo that referenced this pull request Nov 2, 2017
PR-URL: nodejs/node#16632 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Khaidi Chu <[email protected]> Reviewed-By: Brian White <[email protected]>
Qard pushed a commit to ayojs/ayo that referenced this pull request Nov 2, 2017
PR-URL: nodejs/node#16632 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Khaidi Chu <[email protected]> Reviewed-By: Brian White <[email protected]>
cjihrig pushed a commit to cjihrig/node that referenced this pull request Nov 6, 2017
PR-URL: nodejs#16632 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Khaidi Chu <[email protected]> Reviewed-By: Brian White <[email protected]>
Merged
addaleax pushed a commit to ayojs/ayo that referenced this pull request Dec 7, 2017
PR-URL: nodejs/node#16632 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Khaidi Chu <[email protected]> Reviewed-By: Brian White <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
doc