module: revert #3384 DEP0019 EOL#16634
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
The original commit was landed without running CITGM. Unfortunately this change breaks the module `d` which has over 500k downloads a day. It is worth mentioning that the compatibility hack can be removed without breaking anything. We should definitely revisit for the next Semver-Major but shipping this today will cause non trivial ecosystem breakages. Refs: nodejs#3384
nodejs-github-bot added the module ContributorAuthor
MylesBorins commented Oct 31, 2017
Member
targos commented Oct 31, 2017
can you post the citgm failure here please? |
ContributorAuthor
MylesBorins commented Oct 31, 2017
here is an example of one of the failures |
Member
targos commented Oct 31, 2017
thanks. I'm surprised we don't test this use of require. It is common to do that with lodash. |
ContributorAuthor
MylesBorins commented Oct 31, 2017
@targos it seems like this commit specifically broke the case of requiring specific files in modules that only have a single character as a name. This will thankfully be limited to 26 cases! Hopefully this hint can help us with maybe landing this in the future |
jasnell approved these changes Oct 31, 2017
apapirovski approved these changes Oct 31, 2017
cjihrig approved these changes Oct 31, 2017
Member
CI failed completely on windows. Trying again https://ci.nodejs.org/job/node-test-commit-windows-fanned/13041/ |
Member
jasnell commented Oct 31, 2017
@MylesBorins ...
A regression test for specifically this case would be helpful as a separate PR |
Member
Ah, nervermind. When forcing it on (was some semver |
Member
Trying CI on Windows again now that #16639 is landed: https://ci.nodejs.org/job/node-test-commit-windows-fanned/13045/ ... that failed, but I may have restarted it wrong... trying again https://ci.nodejs.org/job/node-test-pull-request/11117/ |
Member
jasnell commented Oct 31, 2017
got past the compile error on windows... should be good but letting the CI finish |
ContributorAuthor
single windows failures edit: make that two |
Member
jasnell commented Oct 31, 2017
Both of which appear to be flaky |
Member
jasnell commented Oct 31, 2017
Just waiting on AIX and OSX to finish... then will get this landed |
jasnell pushed a commit that referenced this pull request Oct 31, 2017
The original commit was landed without running CITGM. Unfortunately this change breaks the module `d` which has over 500k downloads a day. It is worth mentioning that the compatibility hack can be removed without breaking anything. We should definitely revisit for the next Semver-Major but shipping this today will cause non trivial ecosystem breakages. Refs: #3384 PR-URL: #16634 Refs: #3384 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
jasnell pushed a commit that referenced this pull request Oct 31, 2017
The original commit was landed without running CITGM. Unfortunately this change breaks the module `d` which has over 500k downloads a day. It is worth mentioning that the compatibility hack can be removed without breaking anything. We should definitely revisit for the next Semver-Major but shipping this today will cause non trivial ecosystem breakages. Refs: #3384 PR-URL: #16634 Refs: #3384 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Member
jasnell commented Oct 31, 2017
Landed in 45873d2 |
jdalton reviewed Oct 31, 2017
| request.charCodeAt(0)!==46/*.*/|| | ||
| (request.charCodeAt(1)!==46/*.*/&& | ||
| request.charCodeAt(1)!==47/*/*/)){ | ||
| varpaths=modulePaths; |
Member
There was a problem hiding this comment.
The use of charCodeAt jazz really complicates the logic. It was introduced in a pass to optimize lots of things but I suspect it was micro-opts carried a bit too far. Anyways, would this do to fix it:
if(!(request.length===1&&request.charCodeAt(0)===codeOfDot)&&!(request.charCodeAt(0)===codeOfDot&&(request.charCodeAt(1)===codeOfDot||request.charCodeAt(1)===codeOfSlash))){ContributorAuthor
MylesBorins commented Oct 31, 2017 via email
@jdalton do you want to take a pass at a fix + test in a new PR? |
Member
Thanks @MylesBorins! I'm a bit time crunched at the moment but I'd dig picking it up at the end of the week if it's still available. I'll update my comment with findings from my local implementation today. |
Qard pushed a commit to ayojs/ayo that referenced this pull request Nov 2, 2017
The original commit was landed without running CITGM. Unfortunately this change breaks the module `d` which has over 500k downloads a day. It is worth mentioning that the compatibility hack can be removed without breaking anything. We should definitely revisit for the next Semver-Major but shipping this today will cause non trivial ecosystem breakages. Refs: nodejs/node#3384 PR-URL: nodejs/node#16634 Refs: nodejs/node#3384 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Qard pushed a commit to ayojs/ayo that referenced this pull request Nov 2, 2017
The original commit was landed without running CITGM. Unfortunately this change breaks the module `d` which has over 500k downloads a day. It is worth mentioning that the compatibility hack can be removed without breaking anything. We should definitely revisit for the next Semver-Major but shipping this today will cause non trivial ecosystem breakages. Refs: nodejs/node#3384 PR-URL: nodejs/node#16634 Refs: nodejs/node#3384 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
addaleax pushed a commit to ayojs/ayo that referenced this pull request Dec 7, 2017
The original commit was landed without running CITGM. Unfortunately this change breaks the module `d` which has over 500k downloads a day. It is worth mentioning that the compatibility hack can be removed without breaking anything. We should definitely revisit for the next Semver-Major but shipping this today will cause non trivial ecosystem breakages. Refs: nodejs/node#3384 PR-URL: nodejs/node#16634 Refs: nodejs/node#3384 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original commit was landed without running CITGM. Unfortunately
this change breaks the module
dwhich has over 500k downloads a day.It is worth mentioning that the compatibility hack can be removed
without breaking anything.
We should definitely revisit for the next Semver-Major but shipping
this today will cause non trivial ecosystem breakages.
Refs: #3384