Skip to content

Conversation

@MylesBorins
Copy link
Contributor

This also updates the license builder.

@nodejs-github-botnodejs-github-bot added meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory. labels Nov 1, 2017
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

node-inspect :)

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

This also updates the license builder.
Copy link
Member

@mhdawsonmhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawson
Copy link
Member

@MylesBorins
Copy link
ContributorAuthor

landed in 5d0436f

MylesBorins added a commit that referenced this pull request Nov 3, 2017
This also updates the license builder. PR-URL: #16659 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
@richardlau
Copy link
Member

CI run: https://ci.nodejs.org/job/node-test-pull-request/11173/

http2 tests seem to be failing in a bad way, e.g. https://ci.nodejs.org/job/node-test-commit-linuxone/9981/nodes=rhel72-s390x/console. Is this a known issue (it can't possibly be this PR)?

@apapirovski
Copy link
Contributor

ping @jasnell ^

cjihrig pushed a commit to cjihrig/node that referenced this pull request Nov 6, 2017
This also updates the license builder. PR-URL: nodejs#16659 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
@cjihrigcjihrig mentioned this pull request Nov 6, 2017
@MylesBorinsMylesBorins deleted the node-inspect-license branch November 14, 2017 17:42
gibfahn pushed a commit that referenced this pull request Nov 14, 2017
This also updates the license builder. PR-URL: #16659 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
@gibfahngibfahn mentioned this pull request Nov 21, 2017
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

metaIssues and PRs related to the general management of the project.toolsIssues and PRs related to the tools directory.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

12 participants

@MylesBorins@mhdawson@richardlau@apapirovski@jasnell@Fishrock123@maclover7@hiroppy@joyeecheung@gireeshpunathil@gibfahn@nodejs-github-bot