doc: document common pattern for instanceof checks#16699
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added doc 
Member
devsnek commented Nov 2, 2017
can you also document |
MemberAuthor
mhdawson commented Nov 3, 2017
@devsnek I believe |
Member
devsnek commented Nov 3, 2017
@mhdawson ok, sorry for the mixup 👍 |
jasnell approved these changes Nov 3, 2017
cjihrig approved these changes Nov 3, 2017
doc/api/n-api.md Outdated
| status = napi_instanceof(env, es_this, MyClass_constructor, &is_instance); | ||
| assert(napi_ok == status); | ||
| if (is_instance){ | ||
| // napi_unwrap() ... |
Contributor
There was a problem hiding this comment.
Should indentation be two spaces here and a couple lines down?
doc/api/n-api.md Outdated
| } | ||
| ``` | ||
| Of course the reference must be freed once it is no longer needed. |
lpinca approved these changes Nov 5, 2017
MemberAuthor
mhdawson commented Nov 8, 2017
@cjihrig thanks for the comments will update to fix and then land when I'm back from vacation in a week. |
MemberAuthor
mhdawson commented Nov 17, 2017
MemberAuthor
mhdawson commented Nov 17, 2017
Failure on Fedora looks unrelated Given that this is a doc change. |
MemberAuthor
mhdawson commented Nov 17, 2017
Landed as 9b4ab14 |
mhdawson added a commit that referenced this pull request Nov 17, 2017
PR-URL: #16699Fixes: #13824 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
PR-URL: #16699Fixes: #13824 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Merged
gibfahn pushed a commit that referenced this pull request Dec 19, 2017
PR-URL: #16699Fixes: #13824 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Closed
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
PR-URL: #16699Fixes: #13824 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Merged
gabrielschulhof pushed a commit to gabrielschulhof/node that referenced this pull request Apr 16, 2018
PR-URL: nodejs#16699Fixes: nodejs#13824 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
MylesBorins pushed a commit that referenced this pull request Apr 16, 2018
Backport-PR-URL: #19447 PR-URL: #16699Fixes: #13824 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #13824
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
doc