test: fix malformed parallel.status line#16702
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
MemberAuthor
Trott commented Nov 3, 2017
Confirmed locally that this gets rid of the warning about a malformed line. |
MemberAuthor
Trott commented Nov 3, 2017
Ping @refack@cjihrig@MylesBorins @nodejs/testing |
cjihrig approved these changes Nov 3, 2017
Trott referenced this pull request Nov 3, 2017
`parallel/test-async-wrap-uncaughtexception.js` has become flaky. At this time investigating the cause is still on going, but this issue become has prevalent. In order to restore CI status to be relevant, this marks the test as explicitly FLAKY. PR-URL: #16694 Refs: #16210 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Myles Borins <[email protected]>
MylesBorins approved these changes Nov 3, 2017
Contributor
MylesBorins left a comment
MylesBorins left a comment There was a problem hiding this comment.
LGTM
we should land asap to fix CI 🎉
Trott added a commit to Trott/io.js that referenced this pull request Nov 3, 2017
PR-URL: nodejs#16702 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Myles Borins <[email protected]>
MemberAuthor
Trott commented Nov 3, 2017
Landed in 5c475a7. |
cjihrig pushed a commit to cjihrig/node that referenced this pull request Nov 6, 2017
PR-URL: nodejs#16702 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Myles Borins <[email protected]>
Merged
gibfahn pushed a commit that referenced this pull request Nov 14, 2017
PR-URL: #16702 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Myles Borins <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test