[v8.x] deps: V8: backport 32141e9 from upstream#16704
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Original commit message: Disable --turbo-inline-array-builtins by default. Current chrome stable has a high number of crashes due to bugs in this feature. These bugs are already fixed but the fixes are hard to merge back. Therefore we decided to disable the feature in stable. This CL is intended to be merged to stable and then reverted in tot. Bug: chromium:762020 Change-Id: Ibd5a08e3b303a204fb84a408271a1c0f97cc5b7b Reviewed-on: https://chromium-review.googlesource.com/738176 Reviewed-by: Jaroslav Sevcik <[email protected]> Commit-Queue: Georg Neis <[email protected]> Cr-Commit-Position: refs/heads/master@{nodejs#48931} Refs: v8/v8@32141e9
nodejs-github-bot added v8 engine 
targos approved these changes Nov 3, 2017
gireeshpunathil approved these changes Nov 3, 2017
bnoordhuis approved these changes Nov 3, 2017
Contributor
MylesBorins commented Nov 6, 2017
/cc @gibfahn we may want to include this in tomorrow's release |
Contributor
CI was not green... but the fails look infra related One more time : https://ci.nodejs.org/job/node-test-pull-request/11235/ |
Contributor
MylesBorins commented Nov 6, 2017
/cc @maclover7 this does not appear to be getting the status updates from CI |
Contributor
mscdex commented Nov 6, 2017
The statuses show up for me. |
gibfahn pushed a commit that referenced this pull request Nov 7, 2017
Original commit message: Disable --turbo-inline-array-builtins by default. Current chrome stable has a high number of crashes due to bugs in this feature. These bugs are already fixed but the fixes are hard to merge back. Therefore we decided to disable the feature in stable. This CL is intended to be merged to stable and then reverted in tot. Bug: chromium:762020 Change-Id: Ibd5a08e3b303a204fb84a408271a1c0f97cc5b7b Reviewed-on: https://chromium-review.googlesource.com/738176 Reviewed-by: Jaroslav Sevcik <[email protected]> Commit-Queue: Georg Neis <[email protected]> Cr-Commit-Position: refs/heads/master@{#48931} Refs: v8/v8@32141e9 PR-URL: #16704
Member
gibfahn commented Nov 7, 2017
Landed in 6a7e5ce |
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is for
v8.xonly.masterandv9.xwill pick this up in a regular V8 6.2 update.Original commit message:
Refs: v8/v8@32141e9
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
deps:v8
/cc @nodejs/v8
CI: https://ci.nodejs.org/job/node-test-pull-request/11165/
V8-CI: https://ci.nodejs.org/view/All/job/node-test-commit-v8-linux/1031/