build: fix bsd build with gcc#16737
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added the build 
Member
gibfahn commented Nov 4, 2017
Approach looks correct to me, but we don't use cc/ @nodejs/gyp |
mmarchiniforce-pushed the fix-bsd-build-8.6.x branch from e58aa6e to 803871cCompare
ContributorAuthor
mmarchini commented Nov 4, 2017
Changed it to |
bnoordhuis approved these changes Nov 4, 2017
Member
bnoordhuis left a comment
bnoordhuis left a comment There was a problem hiding this comment.
LGTM, thanks. CI: https://ci.nodejs.org/job/node-test-pull-request/11187/
gibfahn approved these changes Nov 4, 2017
ContributorAuthor
mmarchini commented Nov 6, 2017
ARM build failed but it doesn't seem to be related to these changes (see nodejs/build#173) |
jasnell approved these changes Nov 6, 2017
maclover7 approved these changes Nov 24, 2017
refack approved these changes Nov 25, 2017
Contributor
refack commented Nov 25, 2017
@mmarchini could you remove this line as well. Line 10 in ad80c21 And maybe check if o['variables']['llvm_version'] =get_llvm_version(CC) ifis_clangelse0['"0"<llvm_version<"4.0"]works? |
BSD build with GCC was broken because it was checking for the llvm_version variable on common.gypi, even though llvm wasn't installed (or needed). If LLVM wasn't installed, llvm_version wasn't being defined, breaking the build. Fixes: nodejs#16257
mmarchiniforce-pushed the fix-bsd-build-8.6.x branch from 803871c to 62d7469CompareContributorAuthor
mmarchini commented Nov 27, 2017
Yes, it works. Thanks. I've also rebased the branch. |
Contributor
refack commented Nov 27, 2017
refack added the author ready Contributor
refack commented Nov 27, 2017
Landed in 4a7487b. |
refack pushed a commit that referenced this pull request Nov 27, 2017
BSD build with GCC was broken because it was checking for the llvm_version variable on common.gypi, even though llvm wasn't installed (or needed). PR-URL: #16737Fixes: #16257 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
refack removed the author ready MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
BSD build with GCC was broken because it was checking for the llvm_version variable on common.gypi, even though llvm wasn't installed (or needed). PR-URL: #16737Fixes: #16257 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
BSD build with GCC was broken because it was checking for the llvm_version variable on common.gypi, even though llvm wasn't installed (or needed). PR-URL: #16737Fixes: #16257 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
BSD build with GCC was broken because it was checking for the llvm_version variable on common.gypi, even though llvm wasn't installed (or needed). PR-URL: #16737Fixes: #16257 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
Merged
gibfahn pushed a commit that referenced this pull request Dec 19, 2017
BSD build with GCC was broken because it was checking for the llvm_version variable on common.gypi, even though llvm wasn't installed (or needed). PR-URL: #16737Fixes: #16257 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
Member
gibfahn commented Dec 19, 2017
Fix for #14077, should land on 6.x if that lands |
This was referenced Dec 19, 2017
Closed
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
BSD build with GCC was broken because it was checking for the llvm_version variable on common.gypi, even though llvm wasn't installed (or needed). PR-URL: #16737Fixes: #16257 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BSD build with GCC was breaking because it was checking for the
llvm_versionvariable on
common.gypi, even though LLVM wasn't installed (or needed). WhenLLVM wasn't installed,
llvm_versionwasn't being defined, causing the build to break.Fixes: #16257
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
build