test: move timing-sensitive test to sequential

[Trott]

test-https-server-keep-alive-timeout relies on server timeouts and
whatnot that will be inherently unreliable on a busy host. The test
fails when run with a high -j value and higher --repeat value passed
to tools/test.py. Move the test to sequential.

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• commit message follows commit guidelines

Affected core subsystem(s)

test https

[mscdex]

Why does it fail? It's not using a shared port? If it's the setTimeout(), perhaps we should be using the platform timeout variable there?

[Trott]

Why does it fail?

$ tools/test.py -j 96 --repeat 192 test/parallel/test-https-server-keep-alive-timeout.js === release test-https-server-keep-alive-timeout === Path: parallel/test-https-server-keep-alive-timeoutMismatched <anonymous> function calls. Expected exactly 3, actual 1. at Object.exports.mustCall (/Users/trott/io.js/test/common/index.js:490:10) at serverKeepAliveTimeoutWithPipeline (/Users/trott/io.js/test/parallel/test-https-server-keep-alive-timeout.js:34:12) at run (/Users/trott/io.js/test/parallel/test-https-server-keep-alive-timeout.js:28:11) at _combinedTickCallback (internal/process/next_tick.js:131:7) at process._tickCallback (internal/process/next_tick.js:180:9) at Function.Module.runMain (module.js:684:11) at startup (bootstrap_node.js:191:16) at bootstrap_node.js:613:3Command: out/Release/node /Users/trott/io.js/test/parallel/test-https-server-keep-alive-timeout.js[00:12|% 100|+ 191|- 1]: Done  $

perhaps we should be using the platform timeout variable there?

common.platformTimeout() doesn't help on anything other than Raspberry Pi and a few other things. For most hosts, it leaves the value untouched. It might have a small number of valid uses, but generally, we overuse it IMO. Most tests that use it should be in sequential or (better) be refactored to eliminate race conditions.

[Trott]

CI: https://ci.nodejs.org/job/node-test-pull-request/11507/

[Trott]

Landed in 780c2d3.