doc: correct EventEmitter reference#16791
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added doc ContributorAuthor
gowpen commented Nov 6, 2017
@benjamingr Thanks for your very fast reply to this issue. Here's a pull request to fix it. I don't believe new tests are needed so I took that item off the checklist. Wasn't sure if I should be running the existing tests (perhaps to ensure the change hasn't broken code examples in the docs?). Left it on the list and unchecked to start. If it's necessary please let me know and I'll get set up to do it. |
lpinca approved these changes Nov 6, 2017
gireeshpunathil approved these changes Nov 6, 2017
jasnell approved these changes Nov 6, 2017
Member
jasnell left a comment
jasnell left a comment There was a problem hiding this comment.
LGTM. This should need to wait any longer to land
jasnell pushed a commit that referenced this pull request Nov 6, 2017
PR-URL: #16791Fixes: #16789 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: James M Snell <[email protected]>
Member
jasnell commented Nov 6, 2017
Landed in b5f0578 |
cjihrig pushed a commit to cjihrig/node that referenced this pull request Nov 6, 2017
PR-URL: nodejs#16791Fixes: nodejs#16789 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
MylesBorins pushed a commit that referenced this pull request Nov 14, 2017
PR-URL: #16791Fixes: #16789 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
MylesBorins pushed a commit that referenced this pull request Dec 19, 2017
PR-URL: #16791Fixes: #16789 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: James M Snell <[email protected]>
Closed
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
PR-URL: #16791Fixes: #16789 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corrects an erroneous reference to
EventListenermeant to be a reference toEventEmitter.Fixes: #16789
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
doc events