tools: replace string concetation with template literals#16801
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added doc 
cjihrig approved these changes Nov 6, 2017
gireeshpunathil approved these changes Nov 6, 2017
Member
Trott commented Nov 6, 2017
Trott approved these changes Nov 6, 2017
| text=text.replace(/^([^a-z])/,'_$1'); | ||
| if(idCounters.hasOwnProperty(text)){ | ||
| text+='_'+(++idCounters[text]); | ||
| text+=`_${(++idCounters[text])}`; |
Contributor
There was a problem hiding this comment.
A nit (this can be done by whoever will land the PR): parentheses seem redundant now, this can simply be:
text+=`_${++idCounters[text]}`;Member
There was a problem hiding this comment.
Sorry, I missed this comment while landing. Doesn't seem worth force-pushing or doing an additional commit at this point to me, although if someone opens a PR for it, sure, I'm OK with that.
vsemozhetbyt approved these changes Nov 6, 2017
Trott pushed a commit to Trott/io.js that referenced this pull request Nov 6, 2017
Replace string concatenation in tools/doc/html.js with template literals. PR-URL: nodejs#16801 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Member
Trott commented Nov 6, 2017
Landed in 94fb298. Thanks for the contribution! 🎉 |
Trott added the code-and-learn 
2 tasks
cjihrig pushed a commit to cjihrig/node that referenced this pull request Nov 6, 2017
Replace string concatenation in tools/doc/html.js with template literals. PR-URL: nodejs#16801 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Merged
Trott pushed a commit to Trott/io.js that referenced this pull request Nov 6, 2017
PR-URL: nodejs#16845 Ref: nodejs#16801 (comment) Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Rich Trott <[email protected]>
cjihrig pushed a commit to cjihrig/node that referenced this pull request Nov 7, 2017
PR-URL: nodejs#16845 Ref: nodejs#16801 (comment) Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Rich Trott <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 16, 2017
Replace string concatenation in tools/doc/html.js with template literals. PR-URL: #16801 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Rich Trott <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 16, 2017
Replace string concatenation in tools/doc/html.js with template literals. PR-URL: #16801 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Rich Trott <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 16, 2017
PR-URL: #16845 Ref: #16801 (comment) Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Rich Trott <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 16, 2017
PR-URL: #16845 Ref: #16801 (comment) Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Merged
Merged
MylesBorins pushed a commit that referenced this pull request Nov 21, 2017
Replace string concatenation in tools/doc/html.js with template literals. PR-URL: #16801 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Rich Trott <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 21, 2017
PR-URL: #16845 Ref: #16801 (comment) Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Rich Trott <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 28, 2017
Replace string concatenation in tools/doc/html.js with template literals. PR-URL: #16801 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Rich Trott <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 28, 2017
PR-URL: #16845 Ref: #16801 (comment) Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace string concatenation in
tools/doc/html.jswith template literals.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes