test: reaplace fixturesDir with usage of fixtures module#16810
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
repalce common.fixturesDir with usage of the fixtures module Signed-off-by: Octavian Ionescu <[email protected]>
cjihrig approved these changes Nov 6, 2017
Contributor
mscdex commented Nov 6, 2017
Commit message has a typo and unnecessary 'Signed-off-by:' metadata. |
gireeshpunathil added the code-and-learn 
gireeshpunathil approved these changes Nov 6, 2017
Member
gireeshpunathil left a comment
gireeshpunathil left a comment There was a problem hiding this comment.
yes, please remove the unwanted meta in the commit
Member
Trott commented Nov 6, 2017
Trott approved these changes Nov 6, 2017
Trott pushed a commit to Trott/io.js that referenced this pull request Nov 6, 2017
Repalce common.fixturesDir with usage of the fixtures module in test-tls-ecdh-disable. Add a comment explaining the test. PR-URL: nodejs#16810 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Member
Trott commented Nov 6, 2017
Landed in fb31e07. Thanks for the contribution! 🎉 |
cjihrig pushed a commit to cjihrig/node that referenced this pull request Nov 6, 2017
Repalce common.fixturesDir with usage of the fixtures module in test-tls-ecdh-disable. Add a comment explaining the test. PR-URL: nodejs#16810 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Merged
MylesBorins pushed a commit that referenced this pull request Nov 16, 2017
Repalce common.fixturesDir with usage of the fixtures module in test-tls-ecdh-disable. Add a comment explaining the test. PR-URL: #16810 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
repalce common.fixturesDir with usage of the fixtures module
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)