test: change assert messages#16820
Closed
test: change assert messages #16820
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Exceptions that were thrown when they shouldn't were lost.
nodejs-github-bot added dont-land-on-v4.x node-api 
Member
gireeshpunathil commented Nov 6, 2017
@PaulBlanche - looks like you pushed changed without: on your system - implication of which is that this commit will not be associated with your profile. Can you set them up and push once again? |
gireeshpunathil added the code-and-learn 
gireeshpunathil approved these changes Nov 6, 2017
Contributor
vsemozhetbyt commented Nov 6, 2017
@PaulBlanche See also the last note in this chapter: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#setting-up-your-local-environment |
Member
Trott commented Nov 7, 2017
Trott approved these changes Nov 8, 2017
Trott pushed a commit to Trott/io.js that referenced this pull request Nov 8, 2017
Include unexpected value in assertion messages. PR-URL: nodejs#16820 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Member
Trott commented Nov 8, 2017
Landed in e04d23c. Thanks for the contribution! 🎉 |
evanlucas pushed a commit that referenced this pull request Nov 13, 2017
Include unexpected value in assertion messages. PR-URL: #16820 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Merged
gibfahn pushed a commit that referenced this pull request Dec 13, 2017
Include unexpected value in assertion messages. PR-URL: #16820 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Rich Trott <[email protected]>
gabrielschulhof pushed a commit to gabrielschulhof/node that referenced this pull request Apr 16, 2018
Include unexpected value in assertion messages. PR-URL: nodejs#16820 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Rich Trott <[email protected]>
MylesBorins pushed a commit that referenced this pull request Apr 16, 2018
Include unexpected value in assertion messages. Backport-PR-URL: #19447 PR-URL: #16820 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exceptions that were thrown when they shouldn't were lost.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes