Skip to content

test: Improve to use template literals#16929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
deesebas wants to merge 1 commit into from
Closed

test: Improve to use template literals #16929

deesebas wants to merge 1 commit into from

Conversation

@deesebas
Copy link
Contributor

@deesebasdeesebas commented Nov 10, 2017

Checklist
  • [ x] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • [x ] commit message follows commit guidelines
Affected core subsystem(s)

@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label Nov 10, 2017
@gireeshpunathilgireeshpunathil added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 10, 2017
@mscdexmscdex added the net Issues and PRs related to the net subsystem. label Nov 10, 2017
@fhinkel
Copy link
Member

fhinkel commented Nov 11, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/11358/

@fhinkel
Copy link
Member

fhinkel commented Nov 11, 2017

Thanks. Landed in 34006d6

@fhinkelfhinkel closed this Nov 11, 2017
fhinkel pushed a commit that referenced this pull request Nov 11, 2017
@deesebas@fhinkel
test: change concatenated string to template
34006d6
PR-URL: #16929 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]>
evanlucas pushed a commit that referenced this pull request Nov 13, 2017
@deesebas@evanlucas
test: change concatenated string to template
651fee4
PR-URL: #16929 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]>
@evanlucasevanlucas mentioned this pull request Nov 13, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Nov 17, 2017
@deesebas@MylesBorins
test: change concatenated string to template
66387d1
PR-URL: #16929 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 17, 2017
@deesebas@MylesBorins
test: change concatenated string to template
bf9eb04
PR-URL: #16929 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]>
@gibfahngibfahn mentioned this pull request Nov 21, 2017
Merged
@MylesBorinsMylesBorins mentioned this pull request Nov 21, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Nov 21, 2017
@deesebas@MylesBorins
test: change concatenated string to template
8df676c
PR-URL: #16929 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 28, 2017
@deesebas@MylesBorins
test: change concatenated string to template
1d3793e
PR-URL: #16929 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]>
@snyk-botsnyk-bot mentioned this pull request Mar 18, 2020
Open
@snyk-botsnyk-bot mentioned this pull request Apr 1, 2020
Open
@kissofirekissofire mentioned this pull request Mar 7, 2021
Open
@meghasfdcmeghasfdc mentioned this pull request Mar 8, 2021
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fhinkelfhinkelfhinkel approved these changes

@jasnelljasnelljasnell approved these changes

@cjihrigcjihrigcjihrig approved these changes

@tniessentniessentniessen approved these changes

@gireeshpunathilgireeshpunathilgireeshpunathil approved these changes

+2 more reviewers

@apapirovskiapapirovskiapapirovski approved these changes

@vsemozhetbytvsemozhetbytvsemozhetbyt approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

code-and-learnIssues related to the Code-and-Learn events and PRs submitted during the events.netIssues and PRs related to the net subsystem.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

11 participants

@deesebas@fhinkel@apapirovski@jasnell@cjihrig@tniessen@gireeshpunathil@vsemozhetbyt@mscdex@MylesBorins@nodejs-github-bot