deps: cherry-pick upstream ICU fix#16931
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
ICU 60.1 has a bug resulting in incorrect Script_Extensions data for 5 characters. http://bugs.icu-project.org/trac/ticket/13462 Upstream patch: http://bugs.icu-project.org/trac/changeset/40667 Refs: https://bugs.chromium.org/p/v8/issues/detail?id=4743#c54
ContributorAuthor
mathiasbynens commented Nov 10, 2017
jasnell approved these changes Nov 10, 2017
srl295 approved these changes Nov 10, 2017
Member
srl295 left a comment
srl295 left a comment There was a problem hiding this comment.
Sure… I had not realized that this would be a "code" change only, my concern was mostly over data split.
This way it's overwritten if you rebuild node to download ICU, but that's where things are at present.
Merged
Member
mhdawson commented Nov 16, 2017
Member
addaleax commented Nov 18, 2017
Landed in 42bdb66 |
addaleax pushed a commit that referenced this pull request Nov 18, 2017
ICU 60.1 has a bug resulting in incorrect Script_Extensions data for 5 characters. http://bugs.icu-project.org/trac/ticket/13462 Upstream patch: http://bugs.icu-project.org/trac/changeset/40667 Refs: https://bugs.chromium.org/p/v8/issues/detail?id=4743#c54 PR-URL: #16931 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Steven R Loomis <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
ICU 60.1 has a bug resulting in incorrect Script_Extensions data for 5 characters. http://bugs.icu-project.org/trac/ticket/13462 Upstream patch: http://bugs.icu-project.org/trac/changeset/40667 Refs: https://bugs.chromium.org/p/v8/issues/detail?id=4743#c54 PR-URL: #16931 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Steven R Loomis <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Merged
Member
srl295 commented Dec 14, 2017
FWIW this upstream fix landed in ICU 60.2. PR coming soon… |
MylesBorins added baking-for-lts srl295 added a commit that referenced this pull request Jan 18, 2018
- Update to Maintainance ICU 60.2 - CLDR 32.0.1 - http://site.icu-project.org/download/60#TOC-ICU-60.2-bug-fixes - Subsumes #16931 PR-URL: #17687 Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
srl295 added a commit to srl295/node that referenced this pull request Jan 18, 2018
- Update to Maintainance ICU 60.2 - CLDR 32.0.1 - http://site.icu-project.org/download/60#TOC-ICU-60.2-bug-fixes - Subsumes nodejs#16931 PR-URL: nodejs#17687 Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Feb 20, 2018
- Update to Maintainance ICU 60.2 - CLDR 32.0.1 - http://site.icu-project.org/download/60#TOC-ICU-60.2-bug-fixes - Subsumes #16931 PR-URL: #17687 Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
- Update to Maintainance ICU 60.2 - CLDR 32.0.1 - http://site.icu-project.org/download/60#TOC-ICU-60.2-bug-fixes - Subsumes nodejs#16931 PR-URL: nodejs#17687 Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
tniessen removed the baking-for-lts This was referenced Mar 9, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ICU 60.1 has a bug resulting in incorrect
Script_Extensionsdata for 5 characters. http://bugs.icu-project.org/trac/ticket/13462Upstream patch: http://bugs.icu-project.org/trac/changeset/40667
Ref. https://bugs.chromium.org/p/v8/issues/detail?id=4743#c54.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
deps