Skip to content

Conversation

@refack
Copy link
Contributor

test-inspector-async-hook-setup-at-signal is also flaky on VS2017

Refs: #16771

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test,inspector,windows

`test-inspector-async-hook-setup-at-signal` is also flaky on VS2017
@refackrefack added flaky-test Issues and PRs related to the tests with unstable failures on the CI. inspector Issues and PRs related to the V8 inspector protocol test Issues and PRs related to the tests. windows Issues and PRs related to the Windows platform. labels Nov 10, 2017
@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label Nov 10, 2017
@refackrefack added the fast-track PRs that do not need to wait for 48 hours to land. label Nov 10, 2017
@refack
Copy link
ContributorAuthor

Request to fast track. CI gives false negatives, and we are tracking the underlying issue in https://github.com/nodejs/node/projects/8

@refackrefack changed the title test: flag known flaketest: test-inspector-async-hook-setup-at-signal flag as flakyNov 10, 2017
@gireeshpunathil
Copy link
Member

Fast-tracking based on @refack 's request. We have seen this test causing random CI failures so makes sense to isolate before diagnosing

@gireeshpunathil
Copy link
Member

Landed in 074a5c7 , don't know why the commit is not appearing here!

@targostargos closed this Nov 11, 2017
@gireeshpunathil
Copy link
Member

ah, ok - the commit meta is missing! any clues what is the best way to fix it now?

@targos
Copy link
Member

you can add the metadata as a comment at 074a5c7. It's too late to force-push.

gireeshpunathil referenced this pull request Nov 13, 2017
`test-inspector-async-hook-setup-at-signal` is also flaky on VS2017
@gireeshpunathil
Copy link
Member

thanks @targos , done.

@MylesBorins
Copy link
Contributor

MylesBorins commented Dec 6, 2017

@refack you landed this on 8.x-staging. Current process only allows for the backporting team to land on LTS branches

edit: my apologies, looking at commit data it was not landed by you... sorry about that

whoever landed it, please avoid landing things on 8.x-staging or 6.x-staging

@refackrefack reopened this Dec 6, 2017
@refackrefack closed this Dec 6, 2017
@refackrefack deleted the test-inspector-async-hook-setup-at-signal-flake branch December 6, 2017 21:13
MylesBorins referenced this pull request Dec 19, 2017
`test-inspector-async-hook-setup-at-signal` is also flaky on VS2017
gibfahn pushed a commit that referenced this pull request Dec 19, 2017
`test-inspector-async-hook-setup-at-signal` is also flaky on VS2017 PR-URL: #16941 Reviewed-By: Colin Ihrig [email protected] Reviewed-By: Gireesh Punathil [email protected]
@gibfahngibfahn mentioned this pull request Dec 20, 2017
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
`test-inspector-async-hook-setup-at-signal` is also flaky on VS2017 PR-URL: #16941 Reviewed-By: Colin Ihrig [email protected] Reviewed-By: Gireesh Punathil [email protected]
@gibfahngibfahn mentioned this pull request Dec 20, 2017
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fast-trackPRs that do not need to wait for 48 hours to land.flaky-testIssues and PRs related to the tests with unstable failures on the CI.inspectorIssues and PRs related to the V8 inspector protocoltestIssues and PRs related to the tests.windowsIssues and PRs related to the Windows platform.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@refack@gireeshpunathil@targos@MylesBorins@cjihrig@nodejs-github-bot