Skip to content

Conversation

@refack
Copy link
Contributor

with a hydrated cache running npm install while a package-lock.json is present yields an 80% speedup.

d:\code\node\tools\remark-cli$ git clean -xfd Removing node_modules/ Removing package-lock.json d:\code\node\tools\remark-cli$ npm i --production added 272 packages in 16.497s d:\code\node\tools\remark-cli$ rmdir /q /s node_modules\ d:\code\node\tools\remark-cli$ npm i --production added 157 packages in 3.538s 

Fixes: #16628

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

tools

@nodejs-github-botnodejs-github-bot added meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory. labels Nov 10, 2017
@refack
Copy link
ContributorAuthor

/CC @wooorm @nodejs/build

@refack
Copy link
ContributorAuthor

@gibfahn
Copy link
Member

gibfahn commented Nov 10, 2017

Seems like a reasonable solution to me.

Copy link
Contributor

@watildewatilde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@refack
Copy link
ContributorAuthor

I'm just following @zkat's posts, they're the magician behind this. (Can't wait for cipm)

Copy link
Contributor

@XadillaXXadillaX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Trott
Copy link
Member

Trott commented Nov 13, 2017

You probably already did this, but just in case: If we have a documented update process for these things, make sure it removes the package-lock.json and replaces it with a new one. I see, for example, that remark-cli is now up to 4.0.0 and we might want to update soon, I imagine.

@refackrefack closed this Nov 14, 2017
@refackrefack merged commit 61793df into nodejs:masterNov 14, 2017
@refackrefack deleted the mdlint-on-tarball branch November 14, 2017 20:54
MylesBorins pushed a commit that referenced this pull request Dec 11, 2017
by using package-lock.json PR-URL: #16945Fixes: #16628 Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Khaidi Chu <[email protected]> Reviewed-By: James M Snell <[email protected]>
@MylesBorinsMylesBorins mentioned this pull request Dec 12, 2017
@gibfahn
Copy link
Member

Do we want to backport this? I feel like the discussion about what to do with remark hasn't quite finished, so maybe we should hold off. On the other hand we've already backported some of the remark-cli changes to v8.x, so maybe we need to bring this back too.

MylesBorins pushed a commit that referenced this pull request May 22, 2018
by using package-lock.json PR-URL: #16945Fixes: #16628 Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Khaidi Chu <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jun 14, 2018
by using package-lock.json PR-URL: #16945Fixes: #16628 Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Khaidi Chu <[email protected]> Reviewed-By: James M Snell <[email protected]>
@MylesBorinsMylesBorins mentioned this pull request Jul 9, 2018
rvagg pushed a commit that referenced this pull request Aug 16, 2018
by using package-lock.json PR-URL: #16945Fixes: #16628 Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Khaidi Chu <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

metaIssues and PRs related to the general management of the project.toolsIssues and PRs related to the tools directory.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

node-test-linter npm installs remark-cli for each build

12 participants

@refack@gibfahn@Trott@jasnell@watilde@cjihrig@XadillaX@joyeecheung@gireeshpunathil@MylesBorins@BethGriggs@nodejs-github-bot