tools: update to ESLint 4.12.0#16948
Uh oh!
There was an error while loading. Please reload this page.
Conversation
I don't object, but in the past, we've refrained from updating unless it fixed a bug that affected us or provided a feature that we wanted to use. That said, I'm not arguing "We've always done it this way, so we must always do it this way." If we'd rather keep our dependencies more up-to-date more frequently, hey, cool. |
cjihrig commented Nov 26, 2017
I've updated this to 4.12.0. This version comes with a new rule, implicit-arrow-linebreak. I'm not sure if this is a rule we'd want to enable or not. In theory, it looks good, but we have 51 violations that are probably all due to long lines. |
Trott commented Nov 26, 2017
My personal rule of thumb has evolved to be: If people leave nits about it or if people ask explicitly about it, then it needs a rule. Otherwise, no need to enable a rule that no one is otherwise concerned with. So I'd say no need to enable it at this time. (But I don't feel strongly about it if someone else disagrees.) |
PR-URL: nodejs#16948 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
cjihrig commented Nov 28, 2017
CI: https://ci.nodejs.org/job/node-test-pull-request/11767/ None of the failures look related. Landing this. |
PR-URL: #16948 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
PR-URL: #16948 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
PR-URL: #16948 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
PR-URL: #16948 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
PR-URL: #16948 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
6 participants
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
tools