src: remove superfluous check in backtrace_posix.cc#16950
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
The error check doesn't matter because a failure would be ignored as part of the loop condition.
nodejs-github-bot added the c++ 
cjihrig approved these changes Nov 11, 2017
targos approved these changes Nov 11, 2017
refack approved these changes Nov 11, 2017
jasnell approved these changes Nov 12, 2017
gireeshpunathil approved these changes Nov 12, 2017
MemberAuthor
addaleax commented Nov 14, 2017
CI: https://ci.nodejs.org/job/node-test-commit/14022/ This should be ready. |
MemberAuthor
addaleax commented Nov 18, 2017
Landed in 8854598 |
addaleax added a commit that referenced this pull request Nov 18, 2017
The error check doesn't matter because a failure would be ignored as part of the loop condition. PR-URL: #16950 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
The error check doesn't matter because a failure would be ignored as part of the loop condition. PR-URL: #16950 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
Merged
Contributor
MylesBorins commented Dec 19, 2017
@addaleax should this be backported to v6.x or v8.x? |
Contributor
MylesBorins commented Jan 19, 2018
ping @addaleax |
Contributor
MylesBorins commented Feb 27, 2018
ping @addaleax |
MylesBorins pushed a commit that referenced this pull request May 22, 2018
The error check doesn't matter because a failure would be ignored as part of the loop condition. PR-URL: #16950 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jun 14, 2018
The error check doesn't matter because a failure would be ignored as part of the loop condition. PR-URL: #16950 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
Merged
rvagg pushed a commit that referenced this pull request Aug 16, 2018
The error check doesn't matter because a failure would be ignored as part of the loop condition. PR-URL: #16950 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The error check doesn't matter because a failure would be ignored as part of the loop condition.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
src