Skip to content

path: remove obsolete comment#17023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Trott wants to merge 1 commit into from
Closed

path: remove obsolete comment #17023

Trott wants to merge 1 commit into from

Conversation

@Trott
Copy link
Member

@TrottTrott commented Nov 14, 2017

Remove commented-out code that is leftover from a refactoring.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

path

@Trott
path: remove obsolete comment
01405d0
Remove commented-out code that is leftover from a refactoring.
@TrottTrott added the path Issues and PRs related to the path subsystem. label Nov 14, 2017
@Trott
Copy link
MemberAuthor

Trott commented Nov 14, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/11436/

@lance
Copy link
Member

lance commented Nov 16, 2017

Landed in 886c5f4

@lancelance closed this Nov 16, 2017
lance pushed a commit that referenced this pull request Nov 16, 2017
@Trott@lance
path: remove obsolete comment
886c5f4
Remove commented-out code that is leftover from a refactoring. PR-URL: #17023 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Lance Ball <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 11, 2017
@Trott@MylesBorins
path: remove obsolete comment
8366a74
Remove commented-out code that is leftover from a refactoring. PR-URL: #17023 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Lance Ball <[email protected]>
@MylesBorinsMylesBorins mentioned this pull request Dec 12, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Dec 19, 2017
@Trott@MylesBorins
path: remove obsolete comment
a12e168
Remove commented-out code that is leftover from a refactoring. PR-URL: #17023 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Lance Ball <[email protected]>
gibfahn pushed a commit that referenced this pull request Dec 19, 2017
@Trott@gibfahn
path: remove obsolete comment
eb7285d
Remove commented-out code that is leftover from a refactoring. PR-URL: #17023 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Lance Ball <[email protected]>
@gibfahngibfahn mentioned this pull request Dec 20, 2017
Closed
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
@Trott@gibfahn
path: remove obsolete comment
2e1e166
Remove commented-out code that is leftover from a refactoring. PR-URL: #17023 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Lance Ball <[email protected]>
@gibfahngibfahn mentioned this pull request Dec 20, 2017
Merged
@MylesBorinsMylesBorins mentioned this pull request Dec 20, 2017
Merged
@TrottTrott deleted the rm-comment branch January 13, 2022 22:47
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes

@lpincalpincalpinca approved these changes

@cjihrigcjihrigcjihrig approved these changes

@gireeshpunathilgireeshpunathilgireeshpunathil approved these changes

+3 more reviewers

@lancelancelance approved these changes

@apapirovskiapapirovskiapapirovski approved these changes

@refackrefackrefack approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

pathIssues and PRs related to the path subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@Trott@lance@apapirovski@refack@jasnell@lpinca@cjihrig@gireeshpunathil@MylesBorins