Skip to content

Conversation

@refack
Copy link
Contributor

@refackrefack commented Nov 14, 2017

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

tools

@refackrefack requested a review from watildeNovember 14, 2017 21:25
@nodejs-github-botnodejs-github-bot added the tools Issues and PRs related to the tools directory. label Nov 14, 2017
@refack
Copy link
ContributorAuthor

/CC @nodejs/documentation @wooorm

@refackrefack self-assigned this Nov 14, 2017
@addaleax
Copy link
Member

Landed in 66e2751

addaleax pushed a commit that referenced this pull request Nov 18, 2017
PR-URL: #17028 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
PR-URL: #17028 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>
@MylesBorinsMylesBorins mentioned this pull request Dec 12, 2017
@gibfahn
Copy link
Member

Leaving to bake until remark-cli is stable on master, and these can all be backported together to v8.x

@gibfahngibfahn added the baking-for-lts PRs that need to wait before landing in a LTS release. label Dec 19, 2017
@MylesBorinsMylesBorins removed the baking-for-lts PRs that need to wait before landing in a LTS release. label Aug 17, 2018
MylesBorins pushed a commit that referenced this pull request Aug 17, 2018
PR-URL: #17028 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>
@MylesBorinsMylesBorins mentioned this pull request Aug 17, 2018
@refackrefack deleted the bump-remark-to-4 branch September 5, 2018 22:29
@refackrefack removed their assignment Oct 12, 2018
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

toolsIssues and PRs related to the tools directory.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants

@refack@addaleax@gibfahn@jasnell@watilde@cjihrig@MylesBorins@nodejs-github-bot