src: add missing include in node_platform.h#17133
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
addaleax added c++ 
nodejs-github-bot added the c++ 
MemberAuthor
addaleax commented Nov 19, 2017
apapirovski approved these changes Nov 19, 2017
MemberAuthor
addaleax commented Nov 19, 2017
Landed in d61cd9d |
addaleax added a commit that referenced this pull request Nov 19, 2017
PR-URL: #17133 Refs: #17083 Reviewed-By: Anatoli Papirovski <[email protected]>
Member
fhinkel commented Nov 19, 2017
Thank you 🙏 |
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
PR-URL: #17133 Refs: #17083 Reviewed-By: Anatoli Papirovski <[email protected]>
Merged
2 tasks
Member
gibfahn commented Jan 27, 2018
Should come with #17083 if that gets backported to v8.x. |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: #17083
I will fast-track this to un-break CI.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
src/node_platform
@fhinkel