get rid of more not-nice terms#17170
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
aqrln approved these changes Nov 21, 2017
Contributor
There was a problem hiding this comment.
Agreed, colon will yield a cleaner message
gireeshpunathil approved these changes Nov 21, 2017
mscdex added child_process 
targos approved these changes Nov 21, 2017
TimothyGu approved these changes Nov 21, 2017
fhinkel approved these changes Nov 21, 2017
lpinca approved these changes Nov 21, 2017
danbev approved these changes Nov 21, 2017
apapirovski approved these changes Nov 21, 2017
Contributor
There was a problem hiding this comment.
LGTM with the nit from @aqrln fixed, also the commit message would ideally be updated to something like test: clean up inappropriate language or something.
cjihrig approved these changes Nov 21, 2017
devsnekforce-pushed the words branch 2 times, most recently from fff8773 to 6e9b431Compare
aqrln reviewed Nov 21, 2017
| returnparent(); | ||
| default: | ||
| thrownewError(`wtf?${process.argv[2]}`); | ||
| thrownewError(`invalid;${process.argv[2]}`); |
Contributor
There was a problem hiding this comment.
Sorry for being pedantic, but this is a semicolon, not a colon (:) 😄
jasnell approved these changes Nov 21, 2017
Member
jasnell commented Nov 21, 2017
joyeecheung added the fast-track 
Member
joyeecheung commented Nov 21, 2017
Added fast-track although there are already a ton of approvals. |
joyeecheung added the author ready 
Contributor
aqrln commented Nov 22, 2017
+1 to fast-tracking. I went ahead and fixed the nit myself. Gonna land it after the CI finishes green. New CI: https://ci.nodejs.org/job/node-test-pull-request/11623/ |
Contributor
aqrln commented Nov 22, 2017
Landed in 7fd8a21. |
aqrln pushed a commit that referenced this pull request Nov 22, 2017
PR-URL: #17170 Reviewed-By: Alexey Orlenko <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
aqrln removed the author ready MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
PR-URL: #17170 Reviewed-By: Alexey Orlenko <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
PR-URL: #17170 Reviewed-By: Alexey Orlenko <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Merged
MylesBorins pushed a commit that referenced this pull request Dec 19, 2017
PR-URL: #17170 Reviewed-By: Alexey Orlenko <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
gibfahn pushed a commit that referenced this pull request Dec 19, 2017
PR-URL: #17170 Reviewed-By: Alexey Orlenko <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Closed
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
PR-URL: #17170 Reviewed-By: Alexey Orlenko <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Merged
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
18 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this was all i could find with
ackand a bunch of not nice phrases and wordsChecklist
Affected core subsystem(s)