test: wrap callback in common.mustCall#17173
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
gireeshpunathil approved these changes Nov 21, 2017
cjihrig approved these changes Nov 21, 2017
jasnell approved these changes Nov 21, 2017
Member
jasnell commented Nov 21, 2017
This shouldn't need to wait the 48 hours to land once CI passes |
Member
jasnell commented Nov 21, 2017
Trott approved these changes Nov 21, 2017
jasnell pushed a commit that referenced this pull request Nov 21, 2017
PR-URL: #17173 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Member
jasnell commented Nov 21, 2017
Landed in a95d88c. Thank you and congrats on your first PR to core! |
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
PR-URL: #17173 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Merged
MylesBorins pushed a commit that referenced this pull request Dec 19, 2017
PR-URL: #17173 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
gibfahn pushed a commit that referenced this pull request Dec 19, 2017
PR-URL: #17173 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Closed
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
PR-URL: #17173 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Merged
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding common.mustCall to wrap the callback
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
My first contribution to node