test: remove unused parameter#17184
Closed
+1 −3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Member
Thanks for doing this! |
benjamingr approved these changes Nov 21, 2017
targos approved these changes Nov 21, 2017
Member
targos commented Nov 21, 2017
@fdescamps the email address you used in git is not associated with your GitHub account. To make the link, you can go to this page: https://github.com/settings/emails |
Member
targos commented Nov 21, 2017
cjihrig approved these changes Nov 21, 2017
ContributorAuthor
fdescamps commented Nov 21, 2017
It's ok now, thanks @targos |
gireeshpunathil approved these changes Nov 21, 2017
mscdex added the readline 
jasnell approved these changes Nov 21, 2017
Member
jasnell left a comment
jasnell left a comment There was a problem hiding this comment.
This shouldn't need to wait the 48 hours to land once CI comes back green
jasnell pushed a commit that referenced this pull request Nov 21, 2017
PR-URL: #17184 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: James M Snell <[email protected]>
Member
jasnell commented Nov 21, 2017
Landed in ae6368d! Thank you and congrats on your first PR to core! :-) |
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
PR-URL: #17184 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
gibfahn pushed a commit that referenced this pull request Dec 19, 2017
PR-URL: #17184 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: James M Snell <[email protected]>
Closed
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
PR-URL: #17184 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test