build: remove empty VCLibrarianTool entry#17191
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added the build 
jasnell approved these changes Nov 21, 2017
Contributor
refack commented Nov 21, 2017
I always assumed it was left there as a hint that configuring LIB is possible via GYP (since it's not mentioned in the docs) 🤷♂️ |
Contributor
bzoz commented Nov 23, 2017
Member
gibfahn commented Nov 23, 2017
Maybe replace with a comment that says that explicitly? |
gibfahn approved these changes Nov 23, 2017
bzoz approved these changes Nov 23, 2017
ContributorAuthor
danbev commented Nov 23, 2017
There is another usage here and I was thinking that it would be enough as reference. |
refack approved these changes Nov 25, 2017
addaleax approved these changes Nov 27, 2017
addaleax added the author ready ContributorAuthor
danbev commented Nov 27, 2017
Landed in e308142 |
danbev added a commit that referenced this pull request Nov 27, 2017
PR-URL: #17191 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Bartosz Sosnowski <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
addaleax removed the author ready MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
PR-URL: #17191 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Bartosz Sosnowski <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
PR-URL: #17191 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Bartosz Sosnowski <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
PR-URL: #17191 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Bartosz Sosnowski <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Merged
gibfahn pushed a commit that referenced this pull request Dec 19, 2017
PR-URL: #17191 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Bartosz Sosnowski <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
gibfahn pushed a commit that referenced this pull request Dec 19, 2017
PR-URL: #17191 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Bartosz Sosnowski <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Closed
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
PR-URL: #17191 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Bartosz Sosnowski <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Merged
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've come across this empty entry a few times and tried building and running the tests on windows successfully. Wanted to bring this is up in case it was just overlooked.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
build, win
cc @nodejs/build @nodejs/platform-windows