Skip to content

test: remove unused parameter#17193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
franher wants to merge 1 commit into from
Closed

test: remove unused parameter #17193

franher wants to merge 1 commit into from

Conversation

@franher
Copy link
Contributor

@franherfranher commented Nov 21, 2017•
edited
Loading

Checklist
Affected core subsystem(s)
  • test

@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label Nov 21, 2017
@vsemozhetbyt
Copy link
Contributor

vsemozhetbyt commented Nov 21, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/11579/

@mscdexmscdex added the inspector Issues and PRs related to the V8 inspector protocol label Nov 21, 2017
jasnell
jasnell approved these changes Nov 21, 2017
View reviewed changes
Copy link
Member

@jasnelljasnell left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't need to wait the 48 hours to land (just waiting on CI to finish)

@aqrlnaqrln added the fast-track PRs that do not need to wait for 48 hours to land. label Nov 21, 2017
jasnell pushed a commit that referenced this pull request Nov 21, 2017
@franher@jasnell
test: remove unused parameter
3e29e01
PR-URL: #17193 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Alexey Orlenko <[email protected]>
@jasnell
Copy link
Member

jasnell commented Nov 21, 2017

Landed in 3e29e01! Thank you !

@jasnelljasnell closed this Nov 21, 2017
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@franher@MylesBorins
test: remove unused parameter
2bbc1f0
PR-URL: #17193 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Alexey Orlenko <[email protected]>
@MylesBorinsMylesBorins mentioned this pull request Dec 12, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Dec 19, 2017
@franher@MylesBorins
test: remove unused parameter
43e4669
PR-URL: #17193 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Alexey Orlenko <[email protected]>
gibfahn pushed a commit that referenced this pull request Dec 19, 2017
@franher@gibfahn
test: remove unused parameter
1053108
PR-URL: #17193 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Alexey Orlenko <[email protected]>
@gibfahngibfahn mentioned this pull request Dec 20, 2017
Closed
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
@franher@gibfahn
test: remove unused parameter
1f20891
PR-URL: #17193 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Alexey Orlenko <[email protected]>
@gibfahngibfahn mentioned this pull request Dec 20, 2017
Merged
@MylesBorinsMylesBorins mentioned this pull request Dec 20, 2017
Merged
@franherfranher deleted the franher-patch-1 branch November 6, 2018 11:59
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes

@targostargostargos approved these changes

@cjihrigcjihrigcjihrig approved these changes

@gireeshpunathilgireeshpunathilgireeshpunathil approved these changes

+4 more reviewers

@apapirovskiapapirovskiapapirovski approved these changes

@hiroppyhiroppyhiroppy approved these changes

@aqrlnaqrlnaqrln approved these changes

@vsemozhetbytvsemozhetbytvsemozhetbyt approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

fast-trackPRs that do not need to wait for 48 hours to land.inspectorIssues and PRs related to the V8 inspector protocoltestIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

13 participants

@franher@vsemozhetbyt@jasnell@apapirovski@targos@cjihrig@hiroppy@aqrln@gireeshpunathil@mscdex@MylesBorins@gibfahn@nodejs-github-bot