Skip to content

test: use crashOnUnhandledRejection#17219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
purepennons wants to merge 1 commit into from
Closed

test: use crashOnUnhandledRejection #17219

purepennons wants to merge 1 commit into from

Conversation

@purepennons
Copy link
Contributor

@purepennonspurepennons commented Nov 22, 2017

Add common.crashOnUnhandledRejection to test/parallell/test-microtask-queue-integration.js

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

@purepennons
test: use crashOnUnhandledRejection
58acc37
Add common.crashOnUnhandledRejection to test/parallell/test-microtask-queue-integration.js
@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label Nov 22, 2017
MylesBorins
MylesBorins approved these changes Nov 22, 2017
View reviewed changes
Copy link
Contributor

@MylesBorinsMylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MylesBorins
Copy link
Contributor

MylesBorins commented Nov 22, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/11612/

@MylesBorinsMylesBorins added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 22, 2017
@mscdexmscdex added process Issues and PRs related to the process subsystem. v8 engine Issues and PRs related to the V8 dependency. labels Nov 22, 2017
jasnell pushed a commit that referenced this pull request Nov 22, 2017
@purepennons@jasnell
test: use crashOnUnhandledRejection
d7b0c23
Add common.crashOnUnhandledRejection to test-microtask-queue-integration.js PR-URL: #17219 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
@jasnell
Copy link
Member

jasnell commented Nov 22, 2017

Landed in d7b0c23! Thank you and congrats on your PR to core!

@jasnelljasnell closed this Nov 22, 2017
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@purepennons@MylesBorins
test: use crashOnUnhandledRejection
a07ff64
Add common.crashOnUnhandledRejection to test-microtask-queue-integration.js PR-URL: #17219 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@purepennons@MylesBorins
test: use crashOnUnhandledRejection
25ff8be
Add common.crashOnUnhandledRejection to test-microtask-queue-integration.js PR-URL: #17219 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
@MylesBorinsMylesBorins mentioned this pull request Dec 12, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Dec 19, 2017
@purepennons@MylesBorins
test: use crashOnUnhandledRejection
289ebb1
Add common.crashOnUnhandledRejection to test-microtask-queue-integration.js PR-URL: #17219 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
gibfahn pushed a commit that referenced this pull request Dec 19, 2017
@purepennons@gibfahn
test: use crashOnUnhandledRejection
2aacb05
Add common.crashOnUnhandledRejection to test-microtask-queue-integration.js PR-URL: #17219 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
@gibfahngibfahn mentioned this pull request Dec 20, 2017
Closed
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
@purepennons@gibfahn
test: use crashOnUnhandledRejection
b1b9821
Add common.crashOnUnhandledRejection to test-microtask-queue-integration.js PR-URL: #17219 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
@gibfahngibfahn mentioned this pull request Dec 20, 2017
Merged
@MylesBorinsMylesBorins mentioned this pull request Dec 20, 2017
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes

@cjihrigcjihrigcjihrig approved these changes

@gireeshpunathilgireeshpunathilgireeshpunathil approved these changes

+2 more reviewers

@danbevdanbevdanbev approved these changes

@MylesBorinsMylesBorinsMylesBorins approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

code-and-learnIssues related to the Code-and-Learn events and PRs submitted during the events.processIssues and PRs related to the process subsystem.testIssues and PRs related to the tests.v8 engineIssues and PRs related to the V8 dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@purepennons@MylesBorins@jasnell@danbev@cjihrig@gireeshpunathil@mscdex@gibfahn@nodejs-github-bot