test: JSDC workshop#17221
Closed
test: JSDC workshop #17221
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added async_hooks 
Contributor
MylesBorins commented Nov 22, 2017
hey @aryung would you be able to squash your two commits and update the original commit message to include a subsystem. for example it could say
|
MylesBorins added the code-and-learn 
gireeshpunathil approved these changes Nov 22, 2017
cjihrig approved these changes Nov 22, 2017
jasnell approved these changes Nov 22, 2017
Member
jasnell commented Nov 22, 2017
Member
jasnell commented Nov 22, 2017
Squashing and fixing the commit message on landing... |
jasnell pushed a commit that referenced this pull request Nov 22, 2017
PR-URL: #17221 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Member
jasnell commented Nov 22, 2017
Landed in e34cceb! Thank you and congrats on your PR to core! |
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
PR-URL: #17221 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
PR-URL: #17221 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
gibfahn pushed a commit that referenced this pull request Dec 19, 2017
PR-URL: #17221 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Closed
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
PR-URL: #17221 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
just a demo workshop for testing PR..
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)