Add test on unhandled rejection#17228
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor
MylesBorins commented Nov 22, 2017
hey @Larry850806 would you be able to merge all of your changes into a single commit? |
Contributor
MylesBorins commented Nov 22, 2017
gireeshpunathil approved these changes Nov 22, 2017
gireeshpunathil added the code-and-learn 
mscdex added the async_hooks 
cjihrig approved these changes Nov 22, 2017
jasnell approved these changes Nov 22, 2017
Member
jasnell commented Nov 22, 2017
This has some linting issues (it needs a semi-colon) The CI failure on windows appears unrelated. |
Member
jasnell commented Nov 22, 2017
Fixing the linting issue on landing. |
jasnell pushed a commit that referenced this pull request Nov 22, 2017
PR-URL: #17228 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Member
jasnell commented Nov 22, 2017
Landed in 18cf096 with the lint nit fixed. Congrats on your PR to core! |
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
PR-URL: #17228 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
PR-URL: #17228 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
gibfahn pushed a commit that referenced this pull request Dec 19, 2017
PR-URL: #17228 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Closed
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
PR-URL: #17228 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)