test: fix linting error#17251
Closed
test: fix linting error #17251
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
jasnell referenced this pull request Nov 22, 2017
Using an arrow function here eliminates the need to call `bind()`. PR-URL: #17202 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Alexey Orlenko <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
MemberAuthor
jasnell commented Nov 22, 2017
cjihrig approved these changes Nov 22, 2017
jasnell added a commit that referenced this pull request Nov 22, 2017
Fast-tracked on landing to unbreak CI PR-URL: #17251 Reviewed-By: Colin Ihrig <[email protected]>
MemberAuthor
jasnell commented Nov 22, 2017
Landed in cf5ad75 |
joyeecheung added the fast-track MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
Fast-tracked on landing to unbreak CI PR-URL: #17251 Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
Fast-tracked on landing to unbreak CI PR-URL: #17251 Reviewed-By: Colin Ihrig <[email protected]>
Merged
gibfahn pushed a commit that referenced this pull request Dec 19, 2017
Fast-tracked on landing to unbreak CI PR-URL: #17251 Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 19, 2017
Fast-tracked on landing to unbreak CI PR-URL: #17251 Reviewed-By: Colin Ihrig <[email protected]>
Closed
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
Fast-tracked on landing to unbreak CI PR-URL: #17251 Reviewed-By: Colin Ihrig <[email protected]>
Merged
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
571ecd1 landing with a make lint error. This is necessary to fix it. We should fast track to unbreak master.
/cc @lance
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test