doc: Update HTTP -> HTTPS in CONTRIBUTING.md#17261
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
jasnell approved these changes Nov 22, 2017
MylesBorins approved these changes Nov 23, 2017
Contributor
MylesBorins left a comment
MylesBorins left a comment There was a problem hiding this comment.
LGTM
nit: can you please include the subsystem in the commit message anddoc: Update HTTP -> HTTPS in...
Shouldn't have to wait 48 hours
MylesBorins added the fast-track 
URLs were updated to use HTTPS protocol in CONTRIBUTING.md
him2him2force-pushed the _fix_CONTRIBUTING.md_HTTPS branch from c10c208 to 97e315aComparehim2him2 changed the title 
Trott approved these changes Nov 23, 2017
lpinca approved these changes Nov 23, 2017
apapirovski approved these changes Nov 23, 2017
apapirovski pushed a commit that referenced this pull request Nov 23, 2017
PR-URL: #17261 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]>
Contributor
apapirovski commented Nov 23, 2017
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
PR-URL: #17261 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
PR-URL: #17261 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]>
Merged
gibfahn pushed a commit that referenced this pull request Dec 19, 2017
PR-URL: #17261 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]>
gibfahn pushed a commit that referenced this pull request Dec 19, 2017
PR-URL: #17261 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]>
Closed
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
PR-URL: #17261 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]>
Merged
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
URLs were updated to use HTTPS protocol in CONTRIBUTING.md
Checklist
Affected core subsystem(s)
docs