Skip to content

test: remove common.tmpDirName#17266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Trott wants to merge 1 commit into from
Closed

test: remove common.tmpDirName #17266

Trott wants to merge 1 commit into from

Conversation

@Trott
Copy link
Member

@TrottTrott commented Nov 23, 2017

common.tmpDirName is used in only one test and can be replaced with
path.basename(common.tmpDir).

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@Trott
test: remove common.tmpDirName
82332e1
`common.tmpDirName` is used in only one test and can be replaced with `path.basename(common.tmpDir)`.
@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label Nov 23, 2017
Fishrock123
Fishrock123 approved these changes Nov 23, 2017
View reviewed changes
Copy link
Contributor

@Fishrock123Fishrock123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://ci.nodejs.org/job/node-test-pull-request/11676/

@mscdexmscdex added the fs Issues and PRs related to the fs subsystem / file system. label Nov 26, 2017
@joyeecheungjoyeecheung added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 28, 2017
@maclover7
Copy link
Contributor

maclover7 commented Nov 28, 2017

Landing

@maclover7maclover7 self-assigned this Nov 28, 2017
@maclover7
Copy link
Contributor

maclover7 commented Nov 28, 2017

Landed in ecbae56

@TimothyGuTimothyGu removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 29, 2017
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@Trott@MylesBorins
test: remove common.tmpDirName
2839b0a
`common.tmpDirName` is used in only one test and can be replaced with `path.basename(common.tmpDir)`. PR-URL: #17266 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@Trott@MylesBorins
test: remove common.tmpDirName
e9f7c7d
`common.tmpDirName` is used in only one test and can be replaced with `path.basename(common.tmpDir)`. PR-URL: #17266 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@Trott@MylesBorins
test: remove common.tmpDirName
f1b26be
`common.tmpDirName` is used in only one test and can be replaced with `path.basename(common.tmpDir)`. PR-URL: #17266 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>
@MylesBorinsMylesBorins mentioned this pull request Dec 12, 2017
Merged
gibfahn pushed a commit that referenced this pull request Dec 19, 2017
@Trott@gibfahn
test: remove common.tmpDirName
f89efbc
`common.tmpDirName` is used in only one test and can be replaced with `path.basename(common.tmpDir)`. PR-URL: #17266 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>
@gibfahngibfahn mentioned this pull request Dec 20, 2017
Closed
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
@Trott@gibfahn
test: remove common.tmpDirName
0498649
`common.tmpDirName` is used in only one test and can be replaced with `path.basename(common.tmpDir)`. PR-URL: #17266 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>
@gibfahngibfahn mentioned this pull request Dec 20, 2017
Merged
@TrottTrott deleted the rm-tmpDirName branch January 13, 2022 22:47
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpincalpincalpinca approved these changes

@targostargostargos approved these changes

@cjihrigcjihrigcjihrig approved these changes

@richardlaurichardlaurichardlau approved these changes

+3 more reviewers

@Fishrock123Fishrock123Fishrock123 approved these changes

@maclover7maclover7maclover7 approved these changes

@gibfahngibfahngibfahn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@maclover7maclover7

Labels

fsIssues and PRs related to the fs subsystem / file system.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

12 participants

@Trott@maclover7@Fishrock123@lpinca@targos@cjihrig@richardlau@gibfahn@mscdex@TimothyGu@joyeecheung@nodejs-github-bot