Skip to content

test: replace Function with Arrow Function in test-http.js#17305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kouhin wants to merge 1 commit into from
Closed

test: replace Function with Arrow Function in test-http.js #17305

kouhin wants to merge 1 commit into from

Conversation

@kouhin
Copy link

@kouhinkouhin commented Nov 26, 2017•
edited
Loading

Replace replace Function with Arrow Function in test-http.js.

This PR is for Code And Learn in nodefest

Refs: nodejs/code-and-learn#72 (comment)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label Nov 26, 2017
@hiroppyhiroppy added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 26, 2017
@hiroppy
Copy link
Member

hiroppy commented Nov 26, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/11714/

@joyeecheungjoyeecheung added the fast-track PRs that do not need to wait for 48 hours to land. label Nov 26, 2017
@mscdexmscdex added the http Issues or PRs related to the http subsystem. label Nov 26, 2017
@jasnell
Copy link
Member

jasnell commented Nov 26, 2017

One failure in CI was unrelated.

jasnell pushed a commit that referenced this pull request Nov 26, 2017
@jasnell
test: replace function with arrow function
54ff3b6
PR-URL: #17305 Reviewed-By: Yosuke Furukawa <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: James M Snell <[email protected]>
@jasnell
Copy link
Member

jasnell commented Nov 26, 2017

Landed in 54ff3b6. Thank you and congrats on your PR to core!

@jasnelljasnell closed this Nov 26, 2017
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@MylesBorins
test: replace function with arrow function
9a406cd
PR-URL: #17305 Reviewed-By: Yosuke Furukawa <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@MylesBorins
test: replace function with arrow function
3f4d0fc
PR-URL: #17305 Reviewed-By: Yosuke Furukawa <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: James M Snell <[email protected]>
@MylesBorinsMylesBorins mentioned this pull request Dec 12, 2017
Merged
gibfahn pushed a commit that referenced this pull request Dec 19, 2017
@gibfahn
test: replace function with arrow function
6b99341
PR-URL: #17305 Reviewed-By: Yosuke Furukawa <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: James M Snell <[email protected]>
@gibfahngibfahn mentioned this pull request Dec 20, 2017
Closed
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
@gibfahn
test: replace function with arrow function
8874473
PR-URL: #17305 Reviewed-By: Yosuke Furukawa <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: James M Snell <[email protected]>
@gibfahngibfahn mentioned this pull request Dec 20, 2017
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes

@lpincalpincalpinca approved these changes

@gireeshpunathilgireeshpunathilgireeshpunathil approved these changes

+3 more reviewers

@yosuke-furukawayosuke-furukawayosuke-furukawa approved these changes

@watildewatildewatilde approved these changes

@maclover7maclover7maclover7 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

code-and-learnIssues related to the Code-and-Learn events and PRs submitted during the events.fast-trackPRs that do not need to wait for 48 hours to land.httpIssues or PRs related to the http subsystem.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

12 participants

@kouhin@hiroppy@jasnell@yosuke-furukawa@lpinca@watilde@maclover7@gireeshpunathil@mscdex@joyeecheung@gibfahn@nodejs-github-bot