Skip to content

test: fix isNAN->Number.isNAN#17309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ykyz wants to merge 1 commit into from
Closed

test: fix isNAN->Number.isNAN #17309

ykyz wants to merge 1 commit into from
+2 −2

Conversation

@ykyz
Copy link
Contributor

@ykyzykyz commented Nov 26, 2017

This PR is a part of Code And Learn in nodefest nodejs/code-and-learn#72 (comment)

Fix isNAN to Number.isNAN

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label Nov 26, 2017
@vsemozhetbyt
Copy link
Contributor

vsemozhetbyt commented Nov 26, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/11716/

@lpincalpinca added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 26, 2017
@joyeecheungjoyeecheung added the fast-track PRs that do not need to wait for 48 hours to land. label Nov 26, 2017
@mscdexmscdex added the buffer Issues and PRs related to the buffer subsystem. label Nov 26, 2017
jasnell
jasnell approved these changes Nov 26, 2017
View reviewed changes
Copy link
Member

@jasnelljasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failures in CI are unrelated

jasnell pushed a commit that referenced this pull request Nov 26, 2017
@ykyz@jasnell
test: fix isNAN->Number.isNAN
bb44626
PR-URL: #17309 Reviewed-By: Yosuke Furukawa <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: James M Snell <[email protected]>
@jasnell
Copy link
Member

jasnell commented Nov 26, 2017

Landed in bb44626. Thank you and congrats on your PR to core!

@jasnelljasnell closed this Nov 26, 2017
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@ykyz@MylesBorins
test: fix isNAN->Number.isNAN
2cfa6b4
PR-URL: #17309 Reviewed-By: Yosuke Furukawa <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@ykyz@MylesBorins
test: fix isNAN->Number.isNAN
1adccc6
PR-URL: #17309 Reviewed-By: Yosuke Furukawa <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: James M Snell <[email protected]>
@MylesBorinsMylesBorins mentioned this pull request Dec 12, 2017
Merged
gibfahn pushed a commit that referenced this pull request Dec 19, 2017
@ykyz@gibfahn
test: fix isNAN->Number.isNAN
5ac5663
PR-URL: #17309 Reviewed-By: Yosuke Furukawa <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: James M Snell <[email protected]>
gibfahn pushed a commit that referenced this pull request Dec 19, 2017
@ykyz@gibfahn
test: fix isNAN->Number.isNAN
35cc1b3
PR-URL: #17309 Reviewed-By: Yosuke Furukawa <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: James M Snell <[email protected]>
@gibfahngibfahn mentioned this pull request Dec 20, 2017
Closed
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
@ykyz@gibfahn
test: fix isNAN->Number.isNAN
c1efba8
PR-URL: #17309 Reviewed-By: Yosuke Furukawa <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: James M Snell <[email protected]>
@gibfahngibfahn mentioned this pull request Dec 20, 2017
Merged
@MylesBorinsMylesBorins mentioned this pull request Dec 20, 2017
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes

@lpincalpincalpinca approved these changes

@targostargostargos approved these changes

@gireeshpunathilgireeshpunathilgireeshpunathil approved these changes

+3 more reviewers

@yosuke-furukawayosuke-furukawayosuke-furukawa approved these changes

@watildewatildewatilde approved these changes

@maclover7maclover7maclover7 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bufferIssues and PRs related to the buffer subsystem.code-and-learnIssues related to the Code-and-Learn events and PRs submitted during the events.fast-trackPRs that do not need to wait for 48 hours to land.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

13 participants

@ykyz@vsemozhetbyt@jasnell@yosuke-furukawa@lpinca@watilde@targos@maclover7@gireeshpunathil@mscdex@joyeecheung@gibfahn@nodejs-github-bot