Skip to content

test: Replace function with arrow function in test-child-process-send-cb.js#17312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
spring-raining wants to merge 1 commit into from
Closed

test: Replace function with arrow function in test-child-process-send-cb.js #17312

spring-raining wants to merge 1 commit into from

Conversation

@spring-raining
Copy link

@spring-rainingspring-raining commented Nov 26, 2017

Replace some classic functions with arrow functions in test-child-process-send-cb.js

Thie PR is a part of Code and Learn at NodeFest 2017! (nodejs/code-and-learn#72)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

N/A

test: Replace function with arrow function
96014ed
Replace some classic functions with arrow functions in test-child-process-send-cb.js
@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label Nov 26, 2017
@hiroppyhiroppy added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 26, 2017
@vsemozhetbyt
Copy link
Contributor

vsemozhetbyt commented Nov 26, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/11721/

@joyeecheungjoyeecheung added the fast-track PRs that do not need to wait for 48 hours to land. label Nov 26, 2017
@mscdexmscdex added the child_process Issues and PRs related to the child_process subsystem. label Nov 26, 2017
jasnell pushed a commit that referenced this pull request Nov 26, 2017
@jasnell
test: replace function with arrow function
8b68d48
Replace some classic functions with arrow functions in test-child-process-send-cb.js PR-URL: #17312 Reviewed-By: Ron Korving <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: James M Snell <[email protected]>
@jasnell
Copy link
Member

jasnell commented Nov 26, 2017

Landed in 8b68d48. Thank you and congrats on your PR to core!

@jasnelljasnell closed this Nov 26, 2017
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@MylesBorins
test: replace function with arrow function
c5c7e9b
Replace some classic functions with arrow functions in test-child-process-send-cb.js PR-URL: #17312 Reviewed-By: Ron Korving <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@MylesBorins
test: replace function with arrow function
97a279e
Replace some classic functions with arrow functions in test-child-process-send-cb.js PR-URL: #17312 Reviewed-By: Ron Korving <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: James M Snell <[email protected]>
@MylesBorinsMylesBorins mentioned this pull request Dec 12, 2017
Merged
gibfahn pushed a commit that referenced this pull request Dec 19, 2017
@gibfahn
test: replace function with arrow function
1cd4076
Replace some classic functions with arrow functions in test-child-process-send-cb.js PR-URL: #17312 Reviewed-By: Ron Korving <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: James M Snell <[email protected]>
gibfahn pushed a commit that referenced this pull request Dec 19, 2017
@gibfahn
test: replace function with arrow function
afe4c33
Replace some classic functions with arrow functions in test-child-process-send-cb.js PR-URL: #17312 Reviewed-By: Ron Korving <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: James M Snell <[email protected]>
@gibfahngibfahn mentioned this pull request Dec 20, 2017
Closed
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
@gibfahn
test: replace function with arrow function
8b64df0
Replace some classic functions with arrow functions in test-child-process-send-cb.js PR-URL: #17312 Reviewed-By: Ron Korving <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: James M Snell <[email protected]>
@gibfahngibfahn mentioned this pull request Dec 20, 2017
Merged
@MylesBorinsMylesBorins mentioned this pull request Dec 20, 2017
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes

@lpincalpincalpinca approved these changes

@targostargostargos approved these changes

@gireeshpunathilgireeshpunathilgireeshpunathil approved these changes

+4 more reviewers

@ronkorvingronkorvingronkorving approved these changes

@watildewatildewatilde approved these changes

@maclover7maclover7maclover7 approved these changes

@vsemozhetbytvsemozhetbytvsemozhetbyt approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

child_processIssues and PRs related to the child_process subsystem.code-and-learnIssues related to the Code-and-Learn events and PRs submitted during the events.fast-trackPRs that do not need to wait for 48 hours to land.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

14 participants

@spring-raining@vsemozhetbyt@jasnell@ronkorving@lpinca@watilde@targos@maclover7@gireeshpunathil@mscdex@hiroppy@joyeecheung@gibfahn@nodejs-github-bot