doc: Add link of ECMAScript 2015#17317
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added buffer 
hiroppy added the code-and-learn 
yosuke-furukawa approved these changes Nov 26, 2017
Contributor
vsemozhetbyt commented Nov 26, 2017
Memo for a lander: the bottom reference may need to be reinserted in the ABC order. |
Contributor
vsemozhetbyt commented Nov 26, 2017
targos approved these changes Nov 26, 2017
doc/api/buffer.md Outdated
| [RFC1345]: https://tools.ietf.org/html/rfc1345 | ||
| [RFC4648, Section 5]: https://tools.ietf.org/html/rfc4648#section-5 | ||
| [WHATWG Encoding Standard]: https://encoding.spec.whatwg.org/ | ||
| [`ECMAScript 2015`]: http://www.ecma-international.org/ecma-262/6.0/index.html |
Member
There was a problem hiding this comment.
nit: it would be better to have the https URL
joyeecheung added the fast-track 
gireeshpunathil approved these changes Nov 26, 2017
maclover7 approved these changes Nov 26, 2017
Contributor
maclover7 left a comment
maclover7 left a comment There was a problem hiding this comment.
LGTM when link changed to https
jasnell approved these changes Nov 26, 2017
cjihrig approved these changes Nov 26, 2017
hiroppy approved these changes Nov 27, 2017
Contributor
maclover7 commented Nov 28, 2017
maclover7 pushed a commit that referenced this pull request Nov 28, 2017
PR-URL: #17317 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Yosuke Furukawa <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]>
Contributor
maclover7 commented Nov 28, 2017
Landed in 5fdf02b, congrats on your first PR to Node.js! |
Author
sara-o-mt2 commented Nov 28, 2017
Thank you! |
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
PR-URL: #17317 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Yosuke Furukawa <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
PR-URL: #17317 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Yosuke Furukawa <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
PR-URL: #17317 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Yosuke Furukawa <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]>
Merged
gibfahn pushed a commit that referenced this pull request Dec 19, 2017
PR-URL: #17317 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Yosuke Furukawa <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]>
gibfahn pushed a commit that referenced this pull request Dec 19, 2017
PR-URL: #17317 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Yosuke Furukawa <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]>
Closed
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
PR-URL: #17317 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Yosuke Furukawa <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]>
Merged
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is part of Nodefest's Code and Learn nodejs/code-and-learn#72
I add link of ECMAScript 2015.
Checklist
Affected core subsystem(s)