refactor: test cases in test-http-status-reason-invalid-chars to use countdown#17342
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
daxlab approved these changes Nov 27, 2017
mithunsasidharan changed the title test-http-status-reason-invalid-chars file to use countdowntest-http-status-reason-invalid-chars to use countdown
maclover7 approved these changes Nov 27, 2017
Contributor
maclover7 commented Nov 27, 2017
ContributorAuthor
mithunsasidharan commented Dec 3, 2017
@apapirovski : Can you please run the CI for this too ? |
Contributor
apapirovski commented Dec 3, 2017
@mithunsasidharan looks like there's a CI from before that came back green other than known failures. This should be ready to land whenever someone gets a chance. |
apapirovski approved these changes Dec 3, 2017
ContributorAuthor
mithunsasidharan commented Dec 3, 2017
@apapirovski : Thank you ! |
Contributor
maclover7 commented Dec 3, 2017
Landing... |
Contributor
maclover7 commented Dec 3, 2017
Thank you for your contribution, landed in 2afd4e7. |
maclover7 pushed a commit that referenced this pull request Dec 3, 2017
PR-URL: #17342 Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
PR-URL: #17342 Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
PR-URL: #17342 Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]>
Merged
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
PR-URL: #17342 Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]>
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
PR-URL: #17342 Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]>
Closed
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
PR-URL: #17342 Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]>
Merged
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactored
test-http-status-reason-invalid-charsfile to use countdown as per issue #17169Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test