Skip to content

lib: fix typo in TLS_SESSION_ATTACK error#17388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
tomhallam wants to merge 1 commit into from
Closed

lib: fix typo in TLS_SESSION_ATTACK error #17388

tomhallam wants to merge 1 commit into from

Conversation

@tomhallam
Copy link
Contributor

@tomhallamtomhallam commented Nov 29, 2017•
edited by tniessen
Loading

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

errors

@nodejs-github-botnodejs-github-bot added the errors Issues and PRs related to JavaScript errors originated in Node.js core. label Nov 29, 2017
@addaleaxaddaleax added the tls Issues and PRs related to the tls subsystem. label Nov 29, 2017
@tniessen
Copy link
Member

tniessen commented Dec 1, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/11836/

@TrottTrott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 1, 2017
tniessen pushed a commit that referenced this pull request Dec 1, 2017
@tomhallam@tniessen
errors: fix typo in TLS_SESSION_ATTACK message
e9e9863
PR-URL: #17388 Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
@tniessen
Copy link
Member

tniessen commented Dec 1, 2017

Landed in e9e9863, thank you! 🎉 Congratulations for becoming a Node.js contributor!

@tniessentniessen closed this Dec 1, 2017
@addaleaxaddaleax removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 1, 2017
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@tomhallam@MylesBorins
errors: fix typo in TLS_SESSION_ATTACK message
42d614c
PR-URL: #17388 Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@tomhallam@MylesBorins
errors: fix typo in TLS_SESSION_ATTACK message
9c2f24e
PR-URL: #17388 Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
@MylesBorinsMylesBorins mentioned this pull request Dec 12, 2017
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benjamingrbenjamingrbenjamingr approved these changes

@lpincalpincalpinca approved these changes

@cjihrigcjihrigcjihrig approved these changes

@tniessentniessentniessen approved these changes

+2 more reviewers

@TimothyGuTimothyGuTimothyGu approved these changes

@maclover7maclover7maclover7 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

errorsIssues and PRs related to JavaScript errors originated in Node.js core.tlsIssues and PRs related to the tls subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

11 participants

@tomhallam@tniessen@benjamingr@lpinca@TimothyGu@cjihrig@maclover7@Trott@addaleax@gibfahn@nodejs-github-bot