Skip to content

src: node_http2_state.h should not be executable#17408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
maclover7 wants to merge 1 commit into from
Closed

src: node_http2_state.h should not be executable #17408

maclover7 wants to merge 1 commit into from

Conversation

@maclover7
Copy link
Contributor

@maclover7maclover7 commented Dec 1, 2017

Checklist
Affected core subsystem(s)

src

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. dont-land-on-v4.x http2 Issues or PRs related to the http2 subsystem. labels Dec 1, 2017
@addaleaxaddaleax added fast-track PRs that do not need to wait for 48 hours to land. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Dec 1, 2017
@maclover7
Copy link
ContributorAuthor

maclover7 commented Dec 1, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/11841/

@addaleax
Copy link
Member

addaleax commented Dec 1, 2017

Landed in 56e8ee1

@addaleaxaddaleax closed this Dec 1, 2017
addaleax pushed a commit that referenced this pull request Dec 1, 2017
@maclover7@addaleax
src: node_http2_state.h should not be executable
56e8ee1
PR-URL: #17408 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
@addaleaxaddaleax removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 1, 2017
@maclover7maclover7 deleted the jm-http2-rm-exec branch December 1, 2017 21:42
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@maclover7@MylesBorins
src: node_http2_state.h should not be executable
8ad8680
PR-URL: #17408 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@maclover7@MylesBorins
src: node_http2_state.h should not be executable
9b41c0b
PR-URL: #17408 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
@MylesBorinsMylesBorins mentioned this pull request Dec 12, 2017
Merged
gibfahn pushed a commit that referenced this pull request Dec 19, 2017
@maclover7@gibfahn
src: node_http2_state.h should not be executable
9f73ce0
PR-URL: #17408 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
@gibfahngibfahn mentioned this pull request Dec 20, 2017
Closed
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
@maclover7@gibfahn
src: node_http2_state.h should not be executable
c78559e
PR-URL: #17408 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
@gibfahngibfahn mentioned this pull request Dec 20, 2017
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TrottTrottTrott approved these changes

@addaleaxaddaleaxaddaleax approved these changes

@lpincalpincalpinca approved these changes

@cjihrigcjihrigcjihrig approved these changes

@tniessentniessentniessen approved these changes

+3 more reviewers

@apapirovskiapapirovskiapapirovski approved these changes

@thefourtheyethefourtheyethefourtheye approved these changes

@TimothyGuTimothyGuTimothyGu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c++Issues and PRs that require attention from people who are familiar with C++.fast-trackPRs that do not need to wait for 48 hours to land.http2Issues or PRs related to the http2 subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

11 participants

@maclover7@addaleax@apapirovski@thefourtheye@Trott@lpinca@TimothyGu@cjihrig@tniessen@gibfahn@nodejs-github-bot