Skip to content

util: remove check for global.process#17435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
devsnek wants to merge 1 commit into from
Closed

util: remove check for global.process #17435

devsnek wants to merge 1 commit into from

Conversation

@devsnek
Copy link
Member

@devsnekdevsnek commented Dec 3, 2017

process is explicitly passed by NativeModule now, so it doesn't matter it process has been attached to global

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

util

@devsnek
util: remove check for global.process
960f503
process is explicitly passed by NativeModule now, so it doesn't matter it process has been attached to global
@nodejs-github-botnodejs-github-bot added the util Issues and PRs related to the built-in util module. label Dec 3, 2017
@TimothyGu
Copy link
Member

TimothyGu commented Dec 3, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/11857/

@joyeecheungjoyeecheung added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 5, 2017
@apapirovski
Copy link
Contributor

apapirovski commented Dec 8, 2017

Landed in 59711ab

apapirovski pushed a commit that referenced this pull request Dec 8, 2017
@devsnek@apapirovski
util: remove check for global.process
59711ab
process is explicitly passed by NativeModule now. PR-URL: #17435 Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: James M Snell <[email protected]>
@devsnekdevsnek deleted the patch-5 branch December 8, 2017 15:17
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@devsnek@MylesBorins
util: remove check for global.process
ffcb169
process is explicitly passed by NativeModule now. PR-URL: #17435 Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@devsnek@MylesBorins
util: remove check for global.process
c5d20b3
process is explicitly passed by NativeModule now. PR-URL: #17435 Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: James M Snell <[email protected]>
@MylesBorinsMylesBorins mentioned this pull request Dec 12, 2017
Merged
@addaleaxaddaleax removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 13, 2017
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
@devsnek@gibfahn
util: remove check for global.process
cb7739d
process is explicitly passed by NativeModule now. PR-URL: #17435 Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: James M Snell <[email protected]>
@gibfahngibfahn mentioned this pull request Dec 20, 2017
Closed
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
@devsnek@gibfahn
util: remove check for global.process
943258e
process is explicitly passed by NativeModule now. PR-URL: #17435 Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: James M Snell <[email protected]>
@gibfahngibfahn mentioned this pull request Dec 20, 2017
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes

@lpincalpincalpinca approved these changes

@cjihrigcjihrigcjihrig approved these changes

@tniessentniessentniessen approved these changes

@joyeecheungjoyeecheungjoyeecheung approved these changes

@BridgeARBridgeARBridgeAR approved these changes

+2 more reviewers

@TimothyGuTimothyGuTimothyGu approved these changes

@hiroppyhiroppyhiroppy approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

utilIssues and PRs related to the built-in util module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

13 participants

@devsnek@TimothyGu@apapirovski@jasnell@lpinca@cjihrig@tniessen@hiroppy@joyeecheung@BridgeAR@addaleax@gibfahn@nodejs-github-bot