Skip to content

test: use Countdown in http test#17436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mithunsasidharan wants to merge 1 commit into from
Closed

test: use Countdown in http test #17436

mithunsasidharan wants to merge 1 commit into from

Conversation

@mithunsasidharan
Copy link
Contributor

@mithunsasidharanmithunsasidharan commented Dec 3, 2017

refactored test case in test-http-response-multi-content-length to use countdown as per issue #17169

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label Dec 3, 2017
@mscdexmscdex added the http Issues or PRs related to the http subsystem. label Dec 3, 2017
@apapirovski
Copy link
Contributor

apapirovski commented Dec 3, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/11859/

@apapirovski
Copy link
Contributor

apapirovski commented Dec 3, 2017

Nit: the commit title should be adjusted to be < 50 characters.

@mithunsasidharanmithunsasidharan changed the title test: refactored test case in test-http-response-multi-content-length to use countdowntest: refactored test-http-response-multi-content-length to use countdownDec 3, 2017
@mithunsasidharan
Copy link
ContributorAuthor

mithunsasidharan commented Dec 3, 2017

@apapirovski : Update the commit message. Kindly review the PR now. Thanks !

@apapirovski
Copy link
Contributor

apapirovski commented Dec 3, 2017

The commit message still looks too long to me (70 chars or so). I would go with something like test: use Countdown in http test

@mithunsasidharanmithunsasidharan changed the title test: refactored test-http-response-multi-content-length to use countdowntest: use Countdown in http testDec 3, 2017
@mithunsasidharan
Copy link
ContributorAuthor

mithunsasidharan commented Dec 3, 2017

@apapirovski : I've updated the commit message. Kindly review the PR now. Thanks !

@apapirovski
Copy link
Contributor

apapirovski commented Dec 3, 2017

Looks good, thanks!

@tniessen
Copy link
Member

tniessen commented Dec 5, 2017

Landed in 90b257e, thank you!

@tniessentniessen closed this Dec 5, 2017
tniessen pushed a commit that referenced this pull request Dec 5, 2017
@mithunsasidharan@tniessen
test: use Countdown in http test
90b257e
PR-URL: #17436 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@mithunsasidharan@MylesBorins
test: use Countdown in http test
5277156
PR-URL: #17436 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@mithunsasidharan@MylesBorins
test: use Countdown in http test
85e6271
PR-URL: #17436 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
@MylesBorinsMylesBorins mentioned this pull request Dec 12, 2017
Merged
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
@mithunsasidharan@gibfahn
test: use Countdown in http test
8fc1969
PR-URL: #17436 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
@mithunsasidharan@gibfahn
test: use Countdown in http test
52e573d
PR-URL: #17436 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
@gibfahngibfahn mentioned this pull request Dec 20, 2017
Closed
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
@mithunsasidharan@gibfahn
test: use Countdown in http test
fddba18
PR-URL: #17436 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
@gibfahngibfahn mentioned this pull request Dec 20, 2017
Merged
@MylesBorinsMylesBorins mentioned this pull request Dec 20, 2017
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpincalpincalpinca approved these changes

@tniessentniessentniessen approved these changes

+2 more reviewers

@apapirovskiapapirovskiapapirovski approved these changes

@maclover7maclover7maclover7 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

httpIssues or PRs related to the http subsystem.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@mithunsasidharan@apapirovski@tniessen@lpinca@maclover7@mscdex@gibfahn@nodejs-github-bot