test: use common.mustCall in http test#17439
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
daxlab approved these changes Dec 3, 2017
Contributor
apapirovski left a comment
apapirovski left a comment There was a problem hiding this comment.
This test should instead be refactored to use common.mustCall for the response function passed to http.createServer. The nrequests_completed and nrequests_expected variables should still be removed. The server.close() can just be unconditional.
ContributorAuthor
mithunsasidharan commented Dec 3, 2017
@apapirovski : Thanks for the feedback. I've updated the PR to include the recommended changes. Kindly review the PR now. |
apapirovski approved these changes Dec 3, 2017
Contributor
apapirovski left a comment
apapirovski left a comment There was a problem hiding this comment.
LGTM but the commit message & PR title should be updated
Contributor
apapirovski commented Dec 3, 2017
mithunsasidharan changed the title test-http-malformed-request to use countdowntest-http-malformed-request to use common#mustCallmithunsasidharan changed the title test-http-malformed-request to use common#mustCalltest-http-malformed-request to use common.mustCallContributorAuthor
mithunsasidharan commented Dec 3, 2017
@apapirovski : Thats's done too.. Thanks. |
maclover7 approved these changes Dec 3, 2017
Contributor
The commit message is still too long. Something like |
mithunsasidharan changed the title test-http-malformed-request to use common.mustCallContributorAuthor
mithunsasidharan commented Dec 3, 2017
@apapirovski : Thanks for the feedback. I've updated the commit message. Kindly review the PR now. |
tniessen approved these changes Dec 3, 2017
lpinca approved these changes Dec 4, 2017
jasnell approved these changes Dec 5, 2017
maclover7 added the author ready 
Contributor
maclover7 commented Dec 5, 2017
Landing... |
Contributor
maclover7 commented Dec 5, 2017
Thank you for your contribution, landed in f6b2839. |
addaleax removed the author ready MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
PR-URL: #17439 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
PR-URL: #17439 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
PR-URL: #17439 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
PR-URL: #17439 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
Closed
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
PR-URL: #17439 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactored the test case in
test-http-malformed-requestto usecommon.mustCall, as per issue #17169Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test