Enhance Cipheriv, Decipheriv coverage#17458
Closed
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
- Call constructor without new keyword - Call constructor with cipher is not string - Call constructor with cipher is string and key is not string - Call constructor with cipher is strong, key is string and iv is not string
- Call constructor without new keyword - Call constructor with cipher is not string - Call constructor with cipher is string and key is not string - Call constructor with cipher is strong, key is string and iv is not string
Contributor
maclover7 commented Dec 4, 2017
Just a general note, is there any advantage to not using the |
This was referenced Dec 4, 2017
ContributorAuthor
Leko commented Dec 5, 2017
@maclover7 Thank you for your review. |
lpinca approved these changes Dec 5, 2017
maclover7 approved these changes Dec 5, 2017
| constkey='123456789012345678901234'; | ||
| constiv='12345678'; | ||
| constinstance=Cipheriv('des-ede3-cbc',key,iv); |
ContributorAuthor
There was a problem hiding this comment.
This line cannot use createCipheriv because createCipheriv calls constructor with new keyword always.
I want to test call constructor without new keyword.
jasnell approved these changes Dec 5, 2017
BridgeAR approved these changes Dec 6, 2017
maclover7 approved these changes Dec 7, 2017
Contributor
maclover7 commented Dec 7, 2017
maclover7 added the author ready 
Contributor
apapirovski commented Dec 8, 2017
Landed in 6707903 |
apapirovski pushed a commit that referenced this pull request Dec 8, 2017
PR-URL: #17458 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Contributor
MylesBorins commented Dec 12, 2017
This relies on changes in #16527 Setting as don't land for <=v9.x |
addaleax removed the author ready Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added these tests:
Cipheriv
Decipheriv
Current coverage is here: https://coverage.nodejs.org/coverage-06e1b0386196f8f8/root/internal/crypto/cipher.js.html
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test