crypto: declare int return type for set_field#17468
Uh oh!
There was an error while loading. Please reload this page.
Conversation
nodejs-github-bot added c++ 
danbev commented Dec 5, 2017
bnoordhuis commented Dec 6, 2017
The |
danbev commented Dec 6, 2017
Ah I see that now, thanks for clarifying! Is there a reason for not declaring the return type for the function pointer? I've added a commit with what I mean. |
src/node_crypto.cc Outdated
There was a problem hiding this comment.
Since you're threading through the return value, you might as well CHECK_EQ(1, set_field(dh->dh, num));.
There was a problem hiding this comment.
Sounds good, I'll add the check. Thanks
This commit updates the set_field function pointer to return an int, and also updates the lambdas with a return statement.
danbevforce-pushed the crypto_dh_set0_key_void branch from acbe9e6 to 0a1bfc1Comparedanbev changed the title danbev commented Dec 7, 2017
danbev commented Dec 8, 2017
Landed in abc2801 |
This commit updates the set_field function pointer to return an int, and also updates the lambdas with a return statement. PR-URL: #17468 Reviewed-By: Ben Noordhuis <[email protected]>
This commit updates the set_field function pointer to return an int, and also updates the lambdas with a return statement. PR-URL: #17468 Reviewed-By: Ben Noordhuis <[email protected]>
This commit updates the set_field function pointer to return an int, and also updates the lambdas with a return statement. PR-URL: #17468 Reviewed-By: Ben Noordhuis <[email protected]>
gibfahn commented Dec 20, 2017
Should this be backported to |
5 participants
This commit updates the set_field function pointer to return an int, and
also updates the lambdas with a return statement.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
src